Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1rOOXL-003ocH-Qo
	for pgsql-bugs@arkaria.postgresql.org; Fri, 12 Jan 2024 20:53:56 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1rOOWM-005XZN-Ru
	for pgsql-bugs@arkaria.postgresql.org; Fri, 12 Jan 2024 20:52:54 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rOOWM-005XZF-JX
	for pgsql-bugs@lists.postgresql.org; Fri, 12 Jan 2024 20:52:54 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rOOWK-001FrU-6v
	for pgsql-bugs@lists.postgresql.org; Fri, 12 Jan 2024 20:52:53 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 40CKqlFv794096;
	Fri, 12 Jan 2024 15:52:47 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org,
        Richard Guo <guofenglinux@gmail.com>,
        Andres Freund <andres@anarazel.de>, Peter Geoghegan <pg@bowt.ie>
Subject: Re: BUG #17798: Incorrect memory access occurs when using BEFORE ROW
 UPDATE trigger
In-reply-to: 
 <CA+Tgmoa+1HXZAOYiHL5_=+akjyRSDLcHBx-FvmfuwsvFXCkAKg@mail.gmail.com>
References: <17798-0907404928dcf0dd@postgresql.org>
 <87fe6c28-80b2-f709-a8db-d105e5240e39@gmail.com>
 <CAMbWs4_pg7ab=OJF2CGLzs=noWEjujerxfo92sm3RL9ce=ogsQ@mail.gmail.com>
 <CAMbWs48FHhuuuWbxygO4Wey7ahdaSwRjzJODKXx7=GFsge_aLg@mail.gmail.com>
 <f5ff446f-72e2-44f7-80c6-4256cf7caeb3@gmail.com>
 <a4a8cf37-e9d5-3c58-fc2e-d217cf66f315@gmail.com>
 <1849610.1682807087@sss.pgh.pa.us>
 <e989408c-1838-61cd-c968-1fcf47c6fbba@gmail.com>
 <CA+TgmoZz1fGaTnOSf1yQhwYovEEkJZ9iioQXnLgaJz+1fBip=g@mail.gmail.com>
 <494cd7c4-c109-6886-c0e3-138a95e7e38b@gmail.com>
 <CA+TgmoYAsQWMqMUNNdyp8V0KVxMoz=0y+3XNCf3ST-o1yyz5Jg@mail.gmail.com>
 <74335d44-819d-60e0-859a-efe74d9c84c2@gmail.com>
 <CA+TgmoYkOp=jDg15ugJDwxqoA6drAPBZmOJkhZJ11HZWhEYx6w@mail.gmail.com>
 <b64c183f-4ae1-0b16-afcf-11101ebc4213@gmail.com>
 <CA+TgmobRr7iWYNNj+-djD6AkoS5trpL8JznXbfO74+dtmCsOsg@mail.gmail.com>
 <325298.1705009396@sss.pgh.pa.us>
 <94ca869c-472b-f1cf-3d7c-aa8530f5475d@gmail.com>
 <17124cd9-6515-2076-6eac-40d44388f833@gmail.com> <492826.17050!
 80506@sss.pgh.pa.us>
 <CA+Tgmoa+1HXZAOYiHL5_=+akjyRSDLcHBx-FvmfuwsvFXCkAKg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 12 Jan 2024 15:26:22 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <794094.1705092767.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 12 Jan 2024 15:52:47 -0500
Message-ID: <794095.1705092767@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/794095.1705092767%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Jan 12, 2024 at 12:28 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> After sleeping on it, I'm inclined to the opinion that unconditionally
>> materializing newslot here is a good idea.

> I'm glad you came to that conclusion, and I agree.

Cool.

> Do you want to take this forward from here?

Happy to do that, if no one objects to this way forward.

			regards, tom lane