Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xPHLz-00000000ZoA-1S9B for pgsql-bugs@arkaria.postgresql.org; Fri, 06 Nov 2026 10:39:28 +0000 Received: from localhost ([127.0.0.1]:54624 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xPHLy-0000000HBKc-0FB4 for pgsql-bugs@arkaria.postgresql.org; Fri, 06 Nov 2026 10:39:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:46856) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xPHLx-0000000HBKU-3KqP for pgsql-bugs@lists.postgresql.org; Fri, 06 Nov 2026 10:39:25 +0000 Received: from s8.valueserver.jp ([157.7.184.28]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xPHLt-00000000XX7-0BI0 for pgsql-bugs@lists.postgresql.org; Fri, 06 Nov 2026 10:39:23 +0000 Received: from softbank114049171121.bbtec.net ([114.49.171.121] helo=[192.168.3.252]) by s8.valueserver.jp with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.100.1) (envelope-from ) id 1xPHLp-00000002U1q-25ft for pgsql-bugs@lists.postgresql.org; Fri, 06 Nov 2026 19:39:18 +0900 Content-Type: multipart/mixed; boundary="------------qKWSd090Bh0Pg3VtXZ5fCdNu" Message-ID: <7992298c-6f88-4784-bef7-94a860e3a706@interdb.jp> Date: Fri, 6 Nov 2026 19:39:16 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pgsql-bugs@lists.postgresql.org From: Hironobu SUZUKI Subject: EXPLAIN (ANALYZE, FORMAT JSON) emits invalid output for MERGE on a partitioned table List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------qKWSd090Bh0Pg3VtXZ5fCdNu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, While testing, I noticed that EXPLAIN (ANALYZE, FORMAT JSON) of a MERGE whose target is a partitioned table produces syntactically invalid JSON. The MERGE tuple counters ("Tuples Inserted", etc.) are emitted inside the "Target Tables" array, so a bare "key": value pair appears inside a JSON array. Reproducer: CREATE TABLE t (id int) PARTITION BY RANGE (id); CREATE TABLE t1 PARTITION OF t DEFAULT; EXPLAIN (ANALYZE, FORMAT JSON) MERGE INTO t USING (VALUES (1)) s(id) ON t.id = s.id WHEN NOT MATCHED THEN INSERT VALUES (s.id); Actual output (excerpt): "Target Tables": [ { "Relation Name": "t1", "Alias": "t_1" }, "Tuples Inserted": 1, "Tuples Updated": 0, "Tuples Deleted": 0, "Tuples Skipped": 0 ], This is rejected by JSON parsers. With a non-partitioned target, "Target Tables" is not emitted (labeltargets is false), so the counters appear as ordinary properties of the Plan object and the output is valid. I reproduced this on master (commit edbe7ffdc8), 19rc1, 18.6, 17.11, 16.16 and 15.19; the same code is present in all branches that have MERGE. (Text format is unaffected.) Cause: In show_modifytable_info(), the "Target Tables" group is opened before the loop over result relations but is only closed at the very end of the function, after the ON CONFLICT and MERGE properties have been emitted. Those properties belong to the ModifyTable node itself, not to the list of target tables. Patch: The attached patch (against master) closes the "Target Tables" group right after the loop over the target relations. With it, the output for the same query becomes: "Target Tables": [ { "Relation Name": "t1", "Alias": "t_1" } ], "Tuples Inserted": 1, "Tuples Updated": 0, "Tuples Deleted": 0, "Tuples Skipped": 0, I tested the patch on master, 19rc1, 18.6, 17.11, 16.16 and 15.19. It applies to all of them with git apply without modification, the JSON output of the reproducer is valid with it, and make check passes on each. Since the same code is present in all of these branches, a back-patch seems appropriate. Regards, Hironobu Suzuki --------------qKWSd090Bh0Pg3VtXZ5fCdNu Content-Type: text/plain; charset=UTF-8; name="v1-0001-Fix-EXPLAIN-output-of-MERGE-on-partitioned-tables.patch" Content-Disposition: attachment; filename*0="v1-0001-Fix-EXPLAIN-output-of-MERGE-on-partitioned-tables.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0NThmZWVkMzE1ZjdkMWY3YzFmOTM4ZmZkYTdkNDFmYTA1MzAzZGFhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIaXJvbm9idSBTdXp1a2kgPGhpcm9ub2J1QGludGVy ZGIuanA+CkRhdGU6IEZyaSwgNiBOb3YgMjAyNiAxNzo1MToxMyArMDkwMApTdWJqZWN0OiBb UEFUQ0ggdjFdIEZpeCBFWFBMQUlOIG91dHB1dCBvZiBNRVJHRSBvbiBwYXJ0aXRpb25lZCB0 YWJsZXMKCldoZW4gYSBNb2RpZnlUYWJsZSBub2RlIGhhcyBtdWx0aXBsZSB0YXJnZXQgcmVs YXRpb25zLCBzdWNoIGFzIGEKcGFydGl0aW9uZWQgdGFibGUsIHNob3dfbW9kaWZ5dGFibGVf aW5mbygpIG9wZW5zIGEgIlRhcmdldCBUYWJsZXMiCmdyb3VwIGJ1dCBjbG9zZWQgaXQgb25s eSBhZnRlciBlbWl0dGluZyB0aGUgT04gQ09ORkxJQ1QgYW5kIE1FUkdFCnByb3BlcnRpZXMu ICBGb3IgTUVSR0UsIHRoYXQgaW5jbHVkZXMgdGhlICJUdXBsZXMgSW5zZXJ0ZWQiLCAiVHVw bGVzClVwZGF0ZWQiLCAiVHVwbGVzIERlbGV0ZWQiIGFuZCAiVHVwbGVzIFNraXBwZWQiIGNv dW50ZXJzIHNob3duIGJ5CkVYUExBSU4gQU5BTFlaRS4KCkluIHRoZSBzdHJ1Y3R1cmVkIGZv cm1hdHMgdGhvc2UgcHJvcGVydGllcyB0aGVyZWZvcmUgZW5kZWQgdXAgaW5zaWRlCnRoZSAi VGFyZ2V0IFRhYmxlcyIgbGlzdC4gIEluIEpTT04gdGhpcyBpcyBpbnZhbGlkIG91dHB1dCAo YSBiYXJlCiJrZXkiOiB2YWx1ZSBwYWlyIGluc2lkZSBhbiBhcnJheSk7IGluIFlBTUwgYW5k IFhNTCB0aGUgZWxlbWVudHMgd2VyZQpuZXN0ZWQgdW5kZXIgdGhlIHdyb25nIHBhcmVudC4g IFRleHQgZm9ybWF0IHdhcyBub3QgYWZmZWN0ZWQuCgpGaXggYnkgY2xvc2luZyB0aGUgZ3Jv dXAgcmlnaHQgYWZ0ZXIgdGhlIGxvb3Agb3ZlciB0aGUgdGFyZ2V0CnJlbGF0aW9ucywgc28g dGhhdCB0aGVzZSBwcm9wZXJ0aWVzIGFyZSBlbWl0dGVkIGFzIHNpYmxpbmdzIG9mCiJUYXJn ZXQgVGFibGVzIi4KCkJhY2twYXRjaC10aHJvdWdoOiAxNQotLS0KIHNyYy9iYWNrZW5kL2Nv bW1hbmRzL2V4cGxhaW4uYyB8IDEwICsrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQv Y29tbWFuZHMvZXhwbGFpbi5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvZXhwbGFpbi5jCmlu ZGV4IDRiMWFkNDIyN2FjLi5mNTM0ZDFmNjNmZiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQv Y29tbWFuZHMvZXhwbGFpbi5jCisrKyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2V4cGxhaW4u YwpAQCAtNDg3Niw2ICs0ODc2LDEzIEBAIHNob3dfbW9kaWZ5dGFibGVfaW5mbyhNb2RpZnlU YWJsZVN0YXRlICptdHN0YXRlLCBMaXN0ICphbmNlc3RvcnMsCiAJCX0KIAl9CiAKKwkvKgor CSAqIENsb3NlIHRoZSAiVGFyZ2V0IFRhYmxlcyIgZ3JvdXAgYmVmb3JlIGVtaXR0aW5nIHRo ZSBwcm9wZXJ0aWVzIGJlbG93OworCSAqIHRoZXkgYmVsb25nIHRvIHRoZSBNb2RpZnlUYWJs ZSBub2RlIGl0c2VsZiwgbm90IHRvIGl0cyB0YXJnZXQgbGlzdC4KKwkgKi8KKwlpZiAobGFi ZWx0YXJnZXRzKQorCQlFeHBsYWluQ2xvc2VHcm91cCgiVGFyZ2V0IFRhYmxlcyIsICJUYXJn ZXQgVGFibGVzIiwgZmFsc2UsIGVzKTsKKwogCS8qIEdhdGhlciBuYW1lcyBvZiBPTiBDT05G TElDVCBhcmJpdGVyIGluZGV4ZXMgKi8KIAlmb3JlYWNoKGxzdCwgbm9kZS0+YXJiaXRlcklu ZGV4ZXMpCiAJewpAQCAtNDk5OSw5ICs1MDA2LDYgQEAgc2hvd19tb2RpZnl0YWJsZV9pbmZv KE1vZGlmeVRhYmxlU3RhdGUgKm10c3RhdGUsIExpc3QgKmFuY2VzdG9ycywKIAkJCX0KIAkJ fQogCX0KLQotCWlmIChsYWJlbHRhcmdldHMpCi0JCUV4cGxhaW5DbG9zZUdyb3VwKCJUYXJn ZXQgVGFibGVzIiwgIlRhcmdldCBUYWJsZXMiLCBmYWxzZSwgZXMpOwogfQogCiAvKgotLSAK Mi4zOS41IChBcHBsZSBHaXQtMTU0KQoK --------------qKWSd090Bh0Pg3VtXZ5fCdNu--