Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOICH-0006cM-Vj for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Mar 2021 10:54:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOICE-0002rD-Pz for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Mar 2021 10:54:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOICE-0002r5-Jj for pgsql-bugs@lists.postgresql.org; Mon, 22 Mar 2021 10:54:06 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOICB-0007AY-0Z for pgsql-bugs@lists.postgresql.org; Mon, 22 Mar 2021 10:54:04 +0000 Received: from hnk.local (p2350207-ipbf2126funabasi.chiba.ocn.ne.jp [114.167.184.207]) by oss.nttdata.com (Postfix) with ESMTPSA id 76897625A8; Mon, 22 Mar 2021 19:53:56 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table. To: tomohiro hiramitsu Cc: Tom Lane , Kyotaro Horiguchi , Kasahara Tatsuhito , Magnus Hagander , Andres Freund , skoposov@ed.ac.uk, PostgreSQL mailing lists References: <20210301.112452.1902584192027811521.horikyota.ntt@gmail.com> <666801.1614567656@sss.pgh.pa.us> From: Fujii Masao Message-ID: <7b82dd3c-5002-0227-9180-b3c884779a14@oss.nttdata.com> Date: Mon, 22 Mar 2021 19:53:56 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------A8BFA6232FBD7A04D21673C4" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------A8BFA6232FBD7A04D21673C4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2021/03/22 14:43, tomohiro hiramitsu wrote: > Example 2: > GETNEWOID_WARN_MAX_INTERVAL= 128000000 /* (1000000 * 2^7) */ This looks better to me. On 2021/03/22 18:19, tomohiro hiramitsu wrote: > When "LOG" is set, SQL statements can be recorded in the server log even if log_min_error_statement is set to "ERROR"(default). > It would be useful for users to know which SQL statement is retrying to generate OIDs. This makes sense. > In this case, GETNEWOID_WARN_THRESHOLD and GETNEWOID_WARN_MAX_INTERVAL should be renamed to the following names. > > * GETNEWOID_LOG_THRESHOLD > * GETNEWOID_LOG_MAX_INTERVAL Ok, so I updated the patch that way. Patch attached. Barring any objection, I will commit this patch Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------A8BFA6232FBD7A04D21673C4 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="v7-0001-GetNewOidWithIndex_log_output.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="v7-0001-GetNewOidWithIndex_log_output.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvY2F0YWxvZy5jIGIvc3JjL2JhY2tl bmQvY2F0YWxvZy9jYXRhbG9nLmMKaW5kZXggZTJlZDgwYTVkZS4uMjQ1ZDUzNjM3MiAxMDA2 NDQKLS0tIGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9jYXRhbG9nLmMKKysrIGIvc3JjL2JhY2tl bmQvY2F0YWxvZy9jYXRhbG9nLmMKQEAgLTQ3LDYgKzQ3LDEzIEBACiAjaW5jbHVkZSAidXRp bHMvc25hcG1nci5oIgogI2luY2x1ZGUgInV0aWxzL3N5c2NhY2hlLmgiCiAKKy8qCisgKiBQ YXJhbWV0ZXJzIHRvIGRldGVybWluZSB3aGVuIHRvIGVtaXQgYSBsb2cgbWVzc2FnZSBpbgor ICogR2V0TmV3T2lkV2l0aEluZGV4KCkKKyAqLworI2RlZmluZSBHRVRORVdPSURfTE9HX1RI UkVTSE9MRCAxMDAwMDAwCisjZGVmaW5lIEdFVE5FV09JRF9MT0dfTUFYX0lOVEVSVkFMIDEy ODAwMDAwMAorCiAvKgogICogSXNTeXN0ZW1SZWxhdGlvbgogICoJCVRydWUgaWZmIHRoZSBy ZWxhdGlvbiBpcyBlaXRoZXIgYSBzeXN0ZW0gY2F0YWxvZyBvciBhIHRvYXN0IHRhYmxlLgpA QCAtMzE4LDYgKzMyNSw4IEBAIEdldE5ld09pZFdpdGhJbmRleChSZWxhdGlvbiByZWxhdGlv biwgT2lkIGluZGV4SWQsIEF0dHJOdW1iZXIgb2lkY29sdW1uKQogCVN5c1NjYW5EZXNjIHNj YW47CiAJU2NhbktleURhdGEga2V5OwogCWJvb2wJCWNvbGxpZGVzOworCXVpbnQ2NAkJcmV0 cmllcyA9IDA7CisJdWludDY0CQlyZXRyaWVzX2JlZm9yZV9sb2cgPSBHRVRORVdPSURfTE9H X1RIUkVTSE9MRDsKIAogCS8qIE9ubHkgc3lzdGVtIHJlbGF0aW9ucyBhcmUgc3VwcG9ydGVk ICovCiAJQXNzZXJ0KElzU3lzdGVtUmVsYXRpb24ocmVsYXRpb24pKTsKQEAgLTM1Myw4ICsz NjIsNDggQEAgR2V0TmV3T2lkV2l0aEluZGV4KFJlbGF0aW9uIHJlbGF0aW9uLCBPaWQgaW5k ZXhJZCwgQXR0ck51bWJlciBvaWRjb2x1bW4pCiAJCWNvbGxpZGVzID0gSGVhcFR1cGxlSXNW YWxpZChzeXN0YWJsZV9nZXRuZXh0KHNjYW4pKTsKIAogCQlzeXN0YWJsZV9lbmRzY2FuKHNj YW4pOworCisJCS8qCisJCSAqIExvZyB0aGF0IHdlIGl0ZXJhdGUgbW9yZSB0aGFuIEdFVE5F V09JRF9MT0dfVEhSRVNIT0xEIGJ1dCBoYXZlIG5vdAorCQkgKiB5ZXQgZm91bmQgT0lEIHVu dXNlZCBpbiB0aGUgcmVsYXRpb24uIFRoZW4gcmVwZWF0IGxvZ2dpbmcgd2l0aAorCQkgKiBl eHBvbmVudGlhbGx5IGluY3JlYXNpbmcgaW50ZXJ2YWxzIHVudGlsIHdlIGl0ZXJhdGUgbW9y ZSB0aGFuCisJCSAqIEdFVE5FV09JRF9MT0dfTUFYX0lOVEVSVkFMLiBGaW5hbGx5IHJlcGVh dCBsb2dnaW5nIGV2ZXJ5CisJCSAqIEdFVE5FV09JRF9MT0dfTUFYX0lOVEVSVkFMIHVubGVz cyBhbiB1bnVzZWQgT0lEIGlzIGZvdW5kLiBUaGlzCisJCSAqIGxvZ2ljIGlzIG5lY2Vzc2Fy eSBub3QgdG8gZmlsbCB1cCB0aGUgc2VydmVyIGxvZyB3aXRoIHRoZSBzaW1pbGFyCisJCSAq IG1lc3NhZ2VzLgorCQkgKi8KKwkJaWYgKHJldHJpZXMgPj0gcmV0cmllc19iZWZvcmVfbG9n KQorCQl7CisJCQllcmVwb3J0KExPRywKKwkJCQkJKGVycm1zZygic3RpbGwgZmluZGluZyBh biB1bnVzZWQgT0lEIHdpdGhpbiByZWxhdGlvbiBcIiVzXCIiLAorCQkJCQkJCVJlbGF0aW9u R2V0UmVsYXRpb25OYW1lKHJlbGF0aW9uKSksCisJCQkJCSBlcnJkZXRhaWwoIk9JRCBjYW5k aWRhdGVzIHdlcmUgY2hlY2tlZCBcIiVsbHVcIiAgdGltZXMsIGJ1dCBubyB1bnVzZWQgT0lE IGlzIHlldCBmb3VuZC4iLAorCQkJCQkJCSAgICh1bnNpZ25lZCBsb25nIGxvbmcpIHJldHJp ZXMpKSk7CisKKwkJCS8qCisJCQkgKiBEb3VibGUgdGhlIG51bWJlciBvZiByZXRyaWVzIHRv IGRvIGJlZm9yZSBsb2dnaW5nIG5leHQgdW50aWwgaXQKKwkJCSAqIHJlYWNoZXMgR0VUTkVX T0lEX0xPR19NQVhfSU5URVJWQUwuCisJCQkgKi8KKwkJCWlmIChyZXRyaWVzX2JlZm9yZV9s b2cgKiAyIDw9IEdFVE5FV09JRF9MT0dfTUFYX0lOVEVSVkFMKQorCQkJCXJldHJpZXNfYmVm b3JlX2xvZyAqPSAyOworCQkJZWxzZQorCQkJCXJldHJpZXNfYmVmb3JlX2xvZyArPSBHRVRO RVdPSURfTE9HX01BWF9JTlRFUlZBTDsKKwkJfQorCisJCXJldHJpZXMrKzsKIAl9IHdoaWxl IChjb2xsaWRlcyk7CiAKKwkvKgorCSAqIElmIGF0IGxlYXN0IG9uZSBsb2cgbWVzc2FnZSBp cyBlbWl0dGVkLCBhbHNvIGxvZyB0aGUgY29tcGxldGlvbiBvZiBPSUQKKwkgKiBhc3NpZ25t ZW50LgorCSAqLworCWlmIChyZXRyaWVzID4gR0VUTkVXT0lEX0xPR19USFJFU0hPTEQpCisJ eworCQllcmVwb3J0KExPRywKKwkJCQkoZXJybXNnKCJuZXcgT0lEIGhhcyBiZWVuIGFzc2ln bmVkIGluIHJlbGF0aW9uIFwiJXNcIiBhZnRlciBcIiVsbHVcIiByZXRyaWVzIiwKKwkJCQkJ CVJlbGF0aW9uR2V0UmVsYXRpb25OYW1lKHJlbGF0aW9uKSwgKHVuc2lnbmVkIGxvbmcgbG9u ZykgcmV0cmllcykpKTsKKwl9CisKIAlyZXR1cm4gbmV3T2lkOwogfQogCg== --------------A8BFA6232FBD7A04D21673C4--