Message-ID: <7b99b4a7fc5284008bae32b77a776d25b4a400bc.camel@j-davis.com>
Subject: Re: CREATE COLLATION without LOCALE throws error in v15
From: Jeff Davis <pgsql@j-davis.com>
To: Kyle Spearrin <kspearrin@bitwarden.com>, pgsql-bugs@lists.postgresql.org
Cc: Justin Baur <jbaur@bitwarden.com>, Vince Grassia
 <vgrassia@bitwarden.com>,  Peter Eisentraut <peter@eisentraut.org>
Date: Tue, 06 Dec 2022 15:57:19 -0800
In-Reply-To: 
 <CALDQics_oBEYfOnu_zH6yw9WR1waPCmcrqxQ8+39hK3Op=z2UQ@mail.gmail.com>
References: 
	<CALDQics_oBEYfOnu_zH6yw9WR1waPCmcrqxQ8+39hK3Op=z2UQ@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-3qHNIeGbjpGb3CFefFeO"
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/7b99b4a7fc5284008bae32b77a776d25b4a400bc.camel%40j-davis.com>
Precedence: bulk

--=-3qHNIeGbjpGb3CFefFeO
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-12-02 at 14:14 -0500, Kyle Spearrin wrote:
> However, in Postgres 15 we see the following error:
>=20
> ERROR:  parameter "locale" must be specified

I agree that this is some kind of bug. The docs seem pretty clear[1]:

  "locale

    This is a shortcut for setting LC_COLLATE and LC_CTYPE
    at once. If you specify this, you cannot specify either
    of those parameters."

The error appears to come from commit f2553d4306 ("Add option to use
ICU as global locale provider"). My guess is that it was seen as
clearer to write LOCALE, and that the error wasn't expected to cause
anyone a problem. But, given that it's causing a problem for ORMs, we
should fix it.

Simple patch attached. I intend to commit and backpatch to 15 in the
next day or so.

Looking at the docs for CREATE COLLATION[1] and CREATE DATABASE[2], we
could probably do more to make this area consistent. But that's for
another discussion.

[1] https://www.postgresql.org/docs/devel/sql-createcollation.html
[2] https://www.postgresql.org/docs/devel/sql-createdatabase.html


--=20
Jeff Davis
PostgreSQL Contributor Team - AWS


--=-3qHNIeGbjpGb3CFefFeO
Content-Disposition: attachment;
	filename*0=v1-0001-Re-allow-creating-ICU-collation-if-LC_COLLATE-mat.pat;
	filename*1=ch
Content-Type: text/x-patch;
	name="v1-0001-Re-allow-creating-ICU-collation-if-LC_COLLATE-mat.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSBkYjg4NTFhNGI2ZjM4ZDMyMjNhNzIyOWFiYzRkN2EwODczNzI1OGI3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU
dWUsIDYgRGVjIDIwMjIgMTU6MzY6NTQgLTA4MDAKU3ViamVjdDogW1BBVENIIHYxXSBSZS1hbGxv
dyBjcmVhdGluZyBJQ1UgY29sbGF0aW9uIGlmIExDX0NPTExBVEUgbWF0Y2hlcwogTENfQ1RZUEUu
CgpDb21taXQgZjI1NTNkNDMwNiBkaXNhbGxvd2VkIGNyZWF0aW5nIGFuIElDVSBjb2xsYXRpb24g
aWYgTE9DQUxFIHdhcwpub3Qgc3BlY2lmaWVkLiBQcmV2aW91c2x5LCB0aGlzIHdhcyBhbGxvd2Vk
IGFzIGxvbmcgYXMgTENfQ09MTEFURSBhbmQKTENfQ1RZUEUgbWF0Y2hlZC4KCkRpc2N1c3Npb246
IGh0dHBzOi8vcG9zdGdyLmVzL20vQ0FMRFFpY3Nfb0JFWWZPbnVfekg2eXc5V1Ixd2FQQ21jcnF4
UTgrMzloSzNPcD16MlVRQG1haWwuZ21haWwuY29tClJlcG9ydGVkLWJ5OiBLeWxlIFNwZWFycmlu
IDxrc3BlYXJyaW5AYml0d2FyZGVuLmNvbT4KQmFja3BhdGNoLXRocm91Z2g6IDE1Ci0tLQogc3Jj
L2JhY2tlbmQvY29tbWFuZHMvY29sbGF0aW9uY21kcy5jIHwgNCArKysrCiAxIGZpbGUgY2hhbmdl
ZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvY29s
bGF0aW9uY21kcy5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvY29sbGF0aW9uY21kcy5jCmluZGV4
IDgxZTU0ZTBjZTYuLjRiMmYxZDJjMTUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRz
L2NvbGxhdGlvbmNtZHMuYworKysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9jb2xsYXRpb25jbWRz
LmMKQEAgLTI0MCw2ICsyNDAsMTAgQEAgRGVmaW5lQ29sbGF0aW9uKFBhcnNlU3RhdGUgKnBzdGF0
ZSwgTGlzdCAqbmFtZXMsIExpc3QgKnBhcmFtZXRlcnMsIGJvb2wgaWZfbm90X2UKIAkJfQogCQll
bHNlIGlmIChjb2xscHJvdmlkZXIgPT0gQ09MTFBST1ZJREVSX0lDVSkKIAkJeworCQkJaWYgKCFj
b2xsaWN1bG9jYWxlICYmIGNvbGxjb2xsYXRlICYmIGNvbGxjdHlwZSAmJgorCQkJCXN0cmNtcChj
b2xsY29sbGF0ZSwgY29sbGN0eXBlKSA9PSAwKQorCQkJCWNvbGxpY3Vsb2NhbGUgPSBjb2xsY29s
bGF0ZTsKKwogCQkJaWYgKCFjb2xsaWN1bG9jYWxlKQogCQkJCWVyZXBvcnQoRVJST1IsCiAJCQkJ
CQkoZXJyY29kZShFUlJDT0RFX0lOVkFMSURfT0JKRUNUX0RFRklOSVRJT04pLAotLSAKMi4zNC4x
Cgo=


--=-3qHNIeGbjpGb3CFefFeO--