Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwXwY-0000EY-9M for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Sep 2017 18:17:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dwXwX-0002Br-7L for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Sep 2017 18:17:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dwXwW-00029N-5C for pgsql-bugs@postgresql.org; Mon, 25 Sep 2017 18:17:20 +0000 Received: from mail-yw0-x229.google.com ([2607:f8b0:4002:c05::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dwXwO-0003wO-RR for pgsql-bugs@postgresql.org; Mon, 25 Sep 2017 18:17:19 +0000 Received: by mail-yw0-x229.google.com with SMTP id t127so5343305ywg.4 for ; Mon, 25 Sep 2017 11:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=NqMtK5Mbp9o5//4SWiKo5VWuWOXCvPvzfcEWnCcAREU=; b=JH+I9zI/RdLp75pZ1IB2wrbqjIP5Myo/Fv0EvP6lqZis+5QQgWuFCRLGUZ1FlyhMRQ l0dJ+kUC1qbqOuYYf7T/x3y++yvqEWq2PgeuXQ+9fLCkzJszbFy/dFwQLVzl+dbve8jB za4LjYz5Wf4tT2HZ2UV7q2zt3H5hiebO+H3vWKyx4oyc5EOVGkS2gHZIWwOIO/MWfEHN l2VYzXK9TRGAwn0KxvIGOcwpkEuRi9CJ7atLQ1BgG2kJR1tfZUh3hbdEqj5ZvOzcjQsZ evO+EZQZ/1X0rG1E2zsCZKCHtYJD4ACQD4f4i7H/3kKXI4qWuoRhI+cxSiWjIRv7gzWQ kfcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NqMtK5Mbp9o5//4SWiKo5VWuWOXCvPvzfcEWnCcAREU=; b=o8DJD77jc6y/OkNZGkrvjDUt/hYsEBoCXMtbsEv+RiTIbVbsSREQYnFihPiNsKkuDZ TX2EUXdrtoDmY540CmlFF40uecUmx3juL10vTnsKyoKiRsazF1nhlUc3D/YC5Vr0azAS FsvilnrTQvihV48R4Q3LS42fE4zODM10SL7f2jr5WP+4JL2+QZyBQgodQ1JHKzIl/A7O DJco3v1a1MxrjOHFbSaTK/zq/ny3lkg0RomPXB6lPgqgpqZRXscHfxgZBezLQKFqTIh2 05c5ex+ieFpaRfMcdcpxl2DkNcDluqWIEclrpQEhbIELU/ACJjgKPguu7fUPk/7YkRFU +AMw== X-Gm-Message-State: AHPjjUiAMYn/pJo/fHH3Z4V/bK/sIMlEI0hfLwTtfxOr61R+6UYqvFtL GHB8brR0Q2aM+SSsUtzSgRcMr+mQyQ== X-Google-Smtp-Source: AOwi7QAH2hBdVgb1lIKc4QGbgxk6PJrg+y16/azRIf04CyAtYLRasYGJSbxuqelWFj+kRpZo3VnvaA== X-Received: by 10.129.116.197 with SMTP id p188mr5098402ywc.111.1506363431249; Mon, 25 Sep 2017 11:17:11 -0700 (PDT) Received: from [192.168.10.146] ([98.122.175.38]) by smtp.gmail.com with ESMTPSA id q68sm2806015ywe.24.2017.09.25.11.17.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Sep 2017 11:17:10 -0700 (PDT) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: BUG #14825: enum type: unsafe use? To: "David E. Wheeler" Cc: Tom Lane , Christophe Pettus , pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org References: <20170922185904.1448.16585@wrigleys.postgresql.org> <15165.1506116768@sss.pgh.pa.us> <3cece400-af56-7145-2e65-f044de1b0b68@2ndQuadrant.com> <28968.1506136792@sss.pgh.pa.us> <24380.1506179805@sss.pgh.pa.us> <16272.1506189656@sss.pgh.pa.us> <928f5974-151f-0273-0221-fac213e7624f@2ndQuadrant.com> <19137.1506196325@sss.pgh.pa.us> <4942e2c0-3302-f496-d4c1-a967f77d0143@2ndQuadrant.com> <25662.1506204381@sss.pgh.pa.us> <9479302a-09b8-4264-f9c4-514b65f18547@2ndQuadrant.com> <18127.1506285450@sss.pgh.pa.us> <2770f70a-5977-3fa1-1065-11b4cc69f07f@2ndQuadrant.com> <23438.1506294409@sss.pgh.pa.us> <25809.1506348877@sss.pgh.pa.us> <27064.1506350579@sss.pgh.pa.us> <5f4f29bf-90b1-e49a-6cf9-069c59bc1067@2ndQuadrant.com> <40FDB1F3-932D-4912-B4C7-F1E26E331079@justatheory.com> Message-ID: <7ca5214d-f981-54e4-c65a-470a87aa665e@2ndQuadrant.com> Date: Mon, 25 Sep 2017 14:17:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <40FDB1F3-932D-4912-B4C7-F1E26E331079@justatheory.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-MW List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-bugs Precedence: bulk Sender: pgsql-bugs-owner@postgresql.org On 09/25/2017 01:34 PM, David E. Wheeler wrote: > On Sep 25, 2017, at 10:55, Andrew Dunstan wrote: > >> Let's ask a couple of users who I think are or have been actually >> hurting on this point. Christophe and David, any opinions? > If I understand the issue correctly, I think I’d be fine with requiring ALTER TYPE ADD LABEL to be disallowed in a transaction that also CREATEs the type if it’s not currently possible to reliably tell when an enum was created in a transaction. Once you can do that, then by all means allow it! > OK, that seems to be the consensus. So let's apply the blacklist patch and then separately remove the 'created in the same transaction' test. We'll need to adjust the regression tests and docs accordingly. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs