Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIZo6-0002ev-6O for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Apr 2019 14:20:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hIZo3-0006JY-Nu for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Apr 2019 14:20:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIZo2-0006JQ-Lo for pgsql-bugs@lists.postgresql.org; Mon, 22 Apr 2019 14:20:27 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIZnv-00089S-6d for pgsql-bugs@lists.postgresql.org; Mon, 22 Apr 2019 14:20:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZEhE1YdZOOSoWJfQibF/F7qKvpNmZ7plkZexXyX40rU=; b=YlFwq/yVj1rlzNRRraXPtUWIAj b3aSS3h1r9oM7QmavQGXDHPjDZgbJpRDmWLZZbtrM4Q5iMAcbHBK1ZJSECml7YbCiyyaCMV2ok0eR kyhvSqERtNhLgZeL/Re5+U5VpTyL63k5hbeVjE3T4YrLKc6HZ7EPib+K+xjGBRtkx8UMNxQJW3MeF Z7Sm/YwPlfVzSRfJpRw0t8RQPMDVpaYSVLNzzaXne+U3I/uSsDEZPfdSzhkcVfbTLoq6hKDXADtuV Pq52za9CUKKqeY5VkKQm9stAQj8DpeRN2u1D1pZM2AAq/noxP+ZlSWGn/6WmgTdb9/vWFHeBa8ZXa DDqZEGIA==; Received: from [63.118.15.50] (helo=Ph33r-Retina.local) by meldrar.postgresql.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIZnr-0008Cj-DI; Mon, 22 Apr 2019 14:20:17 +0000 Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords To: Tom Lane , Michael Paquier Cc: pgsql-bugs@lists.postgresql.org, Stephen Frost References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> From: "Jonathan S. Katz" Openpgp: preference=signencrypt Autocrypt: addr=jkatz@postgresql.org; keydata= mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC Message-ID: <7e5b5f9e-6cde-b066-837d-9af22e7b1152@postgresql.org> Date: Mon, 22 Apr 2019 10:20:12 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3033.1555940554@sss.pgh.pa.us> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nU9LRPQbmgFndlX5NQVkHhexUmAYBoRuQ" X-Host-Lookup-Failed: Reverse DNS lookup failed for 63.118.15.50 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nU9LRPQbmgFndlX5NQVkHhexUmAYBoRuQ Content-Type: multipart/mixed; boundary="mPMih5WKuPNhDuQ9nM8BiWPjtF4ew0eeN"; protected-headers="v1" From: "Jonathan S. Katz" To: Tom Lane , Michael Paquier Cc: pgsql-bugs@lists.postgresql.org, Stephen Frost Message-ID: <7e5b5f9e-6cde-b066-837d-9af22e7b1152@postgresql.org> Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> In-Reply-To: <3033.1555940554@sss.pgh.pa.us> --mPMih5WKuPNhDuQ9nM8BiWPjtF4ew0eeN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/22/19 9:42 AM, Tom Lane wrote: > Michael Paquier writes: >> On Sat, Apr 20, 2019 at 04:12:56PM -0400, Jonathan S. Katz wrote: >>> I modified the "get_password_type" function to perform a SCRAM >>> verification to see if it is a properly hashed SCRAM password. If it = is, >>> we treat the password as a SCRAM hashed one. Otherwise, we proceed to= >>> the next step, which is to treat it as a plainly stored one. >=20 >> Any objections to back-patch that stuff to v10? >=20 > Patch looks OK as far as it goes, but ISTM it raises an obvious > question: shouldn't the immediately-preceding test to see if a > password is MD5 also be trying harder? Currently it only checks > the length, but verifying that the rest is valid hex data would > go far towards preventing the same set of problems for MD5. >=20 > You might argue that MD5 is deprecated and we shouldn't expend > any effort on it, but a simple strspn check would only require > about one more line ... Yeah, but at least if people look back at it as a reference for how to properly(?) validate various password hashes it would look better. If it was any higher effort, I'd say "no" given the status of md5, but this is fairly innocuous. I'm happy to put something together in a separate patch. I can take a look later today. Jonathan --mPMih5WKuPNhDuQ9nM8BiWPjtF4ew0eeN-- --nU9LRPQbmgFndlX5NQVkHhexUmAYBoRuQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAly9zZwACgkQ8QSccp8c ZSdKaw/9GyNGz1a0vkr7kl/oCevfvmSce5bGeufsTRsPxARuGASQMKXpZzBjICn/ flmOzg0uvCj4wQviXf2En7MT7YEizswCk7YVwzs+p4HJH+HWT0XGDtV3tvj8XvSe ASf7CU7wc1KoN4QFSevmTF2L4Pgw46NIe7LTqF3vJ6iEJeAsFYg/aRfpGC/GV+sB tcJejhR8wJCM8VuEh4IKipQ5tbyncoEJzs9+1mdGOtXqirS7tCvv/Hp0XWvrUG+8 Basn2HYCf9ofM9iVAIqlOPyiRZ8g8a9XPmu38U46Yk3kTAAC93Pjr5G9CpUVWo+P OiA1lpoKrKky9+csypco8oyIFgu8eGnsjUfE7TgGDTEtdFG/vtdNbX5wQDG8rtsJ KicDScjncEp2AQ2gzdHWav3iFygtM3p4dzLz5L/F5am1z8mbykNWdZG6la97DivL IqHGSNZDWwgIwMl6paWYIuK1gXiUZ4oVl+gLa0rZHxmsM5iYywEgKjamVixnTXuh YN+sPTuG/DhBDyb6B/08deJeydN3ZWMP787gfP2Q3ZSoMzo04UMvyJeSClFyFJOV Wz5sA5NcEHoGRUBBQFMbxoM25S1On8m9yELY4Fi0xTWKft/m2VWAQNkc9oHb9UYA /rq2m6eU1Qi7Vn+LySyMVOI9D4fw37LZKPaQTrqCjfV+1wUhckk= =3e2B -----END PGP SIGNATURE----- --nU9LRPQbmgFndlX5NQVkHhexUmAYBoRuQ--