Subject: Re: BUG #16780: Inconsistent recovery_target_xid handling across
 platforms
To: Michael Paquier <michael@paquier.xyz>, pgsql-bugs@lists.postgresql.org
References: <16780-107fd0c0385b1035@postgresql.org>
 <X+BLDQOGr4V5oeBz@paquier.xyz> <X+F99vxLRK8MXAni@paquier.xyz>
 <X+LLO1qy1f8ak96J@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <7e691f38-666e-7991-1107-f87608575560@gmail.com>
Date: Wed, 23 Dec 2020 09:00:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <X+LLO1qy1f8ak96J@paquier.xyz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

23.12.2020 07:44, Michael Paquier wrote:
> On Tue, Dec 22, 2020 at 02:02:46PM +0900, Michael Paquier wrote:
>> So, attached is a patch to make the logic more consistent that I would
>> like to apply down to 12.  Please let me know if there are any
>> objections or comments.
> I have looked at that again this morning, and applied a fix down to
> 9.6 with the change in the TAP tests based on pg_resetwal.  In 9.5,
> pg_strtouint64() is not available, but this branch is old enough that
> it did not seem worth the extra effort.
Thank you!
I think that with this change, if the check for epoch will be added
someday, it will work consistently too.

Best regards,
Alexander