Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3Xp8-0006mA-Ro for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jul 2021 05:52:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m3Xp7-0000YH-2q for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jul 2021 05:52:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3Xp6-0000Y7-RI for pgsql-hackers@lists.postgresql.org; Wed, 14 Jul 2021 05:52:44 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m3Xp4-0001dV-Mh for pgsql-hackers@lists.postgresql.org; Wed, 14 Jul 2021 05:52:43 +0000 Received: by mail-wm1-x32d.google.com with SMTP id n4so793372wms.1 for ; Tue, 13 Jul 2021 22:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=D2KV3QeqjNug51SmbbWgg1rg9tPVwQbPKzj13IgGVfg=; b=jdRfzbgtNW9JBhMPIgHjcrfHZkB9aoHTb9cJHHrnDpeamt/1VjLquW69IrFMpNluY2 P5Ad+Ba46WjZ4JRl1yeQHweYmO+tnCGfX7VRwVjHVwWljHOrnQGUhsT24NjfM00X2Bqg mAP9n5GVVAIXcwZW9nIqV6OrVCoq6UFaOlPtjRmkwYcllOsB9XmUofk9hxltcMrGx67P +wUrxyuV8Dfu9eDsW4FwuiVbTMrfmUc0lpiaJNlKYeFcwy/Bac4zvAJoFrzGHslrr5Df 2OIuFVU7IC5S/9CWzPeeaY2usSAGzPNFIL1zBYmD5E72qAW/A9dAt78csTZXaim8yVmR Fwxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=D2KV3QeqjNug51SmbbWgg1rg9tPVwQbPKzj13IgGVfg=; b=ZnpL8eWkOaSRhwxIsbi8J5Ruvi0fP8m9xt/zkfdKkKowlEzn4iWwWD1r9rWKQPWZym XzBPmHOYT25lMalTV0oJutuCRsa8mBUA52S8GHc3OvPqniGlJgMdd+Gfyv/ZZkzvqTly F3relUx7mb4rdUEAFm//RbZ7ZUGLeCC1yZf67uQ7cyyLXmMu2PxTlNa4H3kcRCVUQJ6Q 3GVhaMddNI5+6ToU/MhWwnlJoNEzeQFg9sitbZ8+8nHZxf3sHWeru4bP4Qn1PDU+3igV RUFXg4tWgRR5G2yKzfvwMXZ5L9KfYCxti6aQBefneGNBawhALmc2ee3fwyW9rJpW0pER Lb1w== X-Gm-Message-State: AOAM533WppKJvTDjvdTSSVk8sfsLu406RwBDjGu+9zztWhuXasqo+9X1 FhPtFnbpstaYSGYV4pLcSniORnnSDZoFMg== X-Google-Smtp-Source: ABdhPJxi6fa5SUp7boBx+eNhJnd4/RCiaGfl0nXlqilDPhc+f5J4uy7MeMkWhJLQzHfUJOj5OhH5Bg== X-Received: by 2002:a1c:6a18:: with SMTP id f24mr2066983wmc.10.1626241961062; Tue, 13 Jul 2021 22:52:41 -0700 (PDT) Received: from localhost.localdomain (217-149-168-54.nat.highway.telekom.at. [217.149.168.54]) by smtp.gmail.com with ESMTPSA id o18sm1172810wrx.21.2021.07.13.22.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 22:52:40 -0700 (PDT) Message-ID: <802d1a9448570ed6b14d0c8d57746c3a3cd55695.camel@cybertec.at> Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped) From: Laurenz Albe To: Tom Lane , Ranier Vilela Cc: PostgreSQL Hackers Date: Wed, 14 Jul 2021 07:52:39 +0200 In-Reply-To: <3280448.1626200778@sss.pgh.pa.us> References: <17098-b960f3616c861f83@postgresql.org> <2468663.1626017338@sss.pgh.pa.us> <2984422.1626110456@sss.pgh.pa.us> <3227956.1626186568@sss.pgh.pa.us> <3280448.1626200778@sss.pgh.pa.us> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 2021-07-13 at 14:26 -0400, Tom Lane wrote: > Did you see my followup? The vast majority of live systems do not do > that, so we are accomplishing nothing of value by insisting it's a > crash-worthy bug. > > I flat out don't agree that "crash on debug builds but it's okay on > production" is a useful way to define this. I spend way too much > time already on bug reports that only manifest with asserts enabled. You convinced my that printing "(null)" is better than crashing. Having a "(null)" show up in a weird place is certainly a minor inconvenience. But I don't buy your second point: if it is like that, why do we have Asserts at all? Yours, Laurenz Albe