From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
cc: d.kovalenko@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18960: Mistake in test test_simple_pipeline
 (libpq_pipeline.c)
In-reply-to: <202509031228.wuh3frddxcvl@alvherre.pgsql>
References: <202509031228.wuh3frddxcvl@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
	message dated "Wed, 03 Sep 2025 14:28:30 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <803145.1756910897.1@sss.pgh.pa.us>
Date: Wed, 03 Sep 2025 10:48:17 -0400
Message-ID: <803146.1756910897@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/803146.1756910897%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Jun-21, Tom Lane wrote:
>> Here's a shot at improving matters.  I also made an effort
>> at cleaning up memory leaks in libpq_pipeline.c, although
>> that's surely neatnik-ism not anything meaningful.

> Yeah, the code looks much better this way.  I thought it was a bit odd
> that a function called confirm_result_status() would actually consume
> said status.  Would it be better as
>   consume_result_status(PGconn *conn, ExecStatusType expected)
> ?

Hm, I chose that name by analogy to the adjacent
confirm_query_canceled(), which is likewise consuming a result.
I agree that "consume" is a better verb, but then let's rename
confirm_query_canceled as well.

> I think the patch is a clear improvement regardless.

Thanks for reviewing!

			regards, tom lane