Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1ubXlO-0027cb-B0
	for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Jul 2025 04:59:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1ubXlL-00H2tK-JB
	for pgsql-bugs@arkaria.postgresql.org; Tue, 15 Jul 2025 04:59:32 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ubXlL-00H2tC-Ab
	for pgsql-bugs@lists.postgresql.org; Tue, 15 Jul 2025 04:59:31 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ubXlK-007Lih-0i
	for pgsql-bugs@lists.postgresql.org;
	Tue, 15 Jul 2025 04:59:31 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 56F4xQss834746;
	Tue, 15 Jul 2025 00:59:26 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>,
        exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18984: Empty prepared statement from psql \parse triggers
 assert in PortalRunMulti
In-reply-to: <aHXeledtL7CCUNKd@paquier.xyz>
References: <18984-0f4778a6599ac3ae@postgresql.org>
 <715434.1752521761@sss.pgh.pa.us> <799185.1752535067@sss.pgh.pa.us>
 <aHXeledtL7CCUNKd@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 15 Jul 2025 13:52:37 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <834744.1752555566.1@sss.pgh.pa.us>
Date: Tue, 15 Jul 2025 00:59:26 -0400
Message-ID: <834745.1752555566@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/834745.1752555566%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> ... I am wondering if we should not just nuke the assertion at the end
> of PortalRunMulti() instead, relying on the same check done at the
> beginning of ProcessUtility().

Yeah, I was starting to think about that solution too.  Removing
code seems nicer than adding more.

CC'ing Alvaro as the original author...

			regards, tom lane