From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Andres Freund <andres@anarazel.de>, xinwen@stu.scu.edu.cn,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c
In-reply-to: 
 <CAApHDvpeXSU4A=mzX=96Rdn6u4gjVLHy8SMaVm_g01S8yhfAoQ@mail.gmail.com>
References: <17777-860b739b6efde977@postgresql.org>
 <20230210230230.scuk6gqrks6c7sc7@awork3.anarazel.de>
 <439391.1676070752@sss.pgh.pa.us>
 <20230210232051.efjhtoqo6odk3gke@awork3.anarazel.de>
 <443909.1676073430@sss.pgh.pa.us>
 <20230211004940.t5l2dz7rnss76zao@awork3.anarazel.de>
 <CAApHDvpeXSU4A=mzX=96Rdn6u4gjVLHy8SMaVm_g01S8yhfAoQ@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Sun, 12 Feb 2023 23:30:25 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <842392.1676218781.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 12 Feb 2023 11:19:41 -0500
Message-ID: <842393.1676218781@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/842393.1676218781%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Sat, 11 Feb 2023 at 13:49, Andres Freund <andres@anarazel.de> wrote:
>> I think we could just add a !contain_subplans() to the code deciding wh=
ether
>> it's safe to use the movable window optimization?

> I think this is a fair way to fix the bug.

Agreed.

> Here's a patch for that.

Why is it okay to check only the filter, and not the rest of the
WindowFunc's subexpressions?  The arguments we've just run through
seem to apply to a subplan in the direct or aggregated arguments
as well.

			regards, tom lane