From: Tom Lane <tgl@sss.pgh.pa.us>
To: Artur Zakirov <zaartur@gmail.com>
cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_dump crash on identity sequence with not loaded attributes
In-reply-to: 
 <CAKNkYnwR0iLr2YeB9dkDXqh1vXvCyx9VyYTxw_mppCbkjqwP0A@mail.gmail.com>
References: 
 <CAKNkYnwXFBf136=u9UqUxFUVagevLQJ=zGd5BsLhCsatDvQsKQ@mail.gmail.com>
 <4137493.1733781111@sss.pgh.pa.us>
 <CAKNkYnwTypJPsc258ZwVJ+n_Ti-8VxiQ6Gy4oMPmCA9fKo+KKg@mail.gmail.com>
 <66804.1733844592@sss.pgh.pa.us>
 <CAKNkYnwR0iLr2YeB9dkDXqh1vXvCyx9VyYTxw_mppCbkjqwP0A@mail.gmail.com>
Comments: In-reply-to Artur Zakirov <zaartur@gmail.com>
	message dated "Tue, 10 Dec 2024 18:54:22 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <84248.1733854089.1@sss.pgh.pa.us>
Date: Tue, 10 Dec 2024 13:08:09 -0500
Message-ID: <84249.1733854089@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/84249.1733854089%40sss.pgh.pa.us>
Precedence: bulk

Artur Zakirov <zaartur@gmail.com> writes:
> Alternatively, instead of forcing owning_tab->interesting to true, I
> think we could always initialize owning_tab's attributes (i.e. arrays
> like owning_tab->attnames, owning_tab->attidenity), which are used by
> dumpSequence() and which causes the crash. Are there any downsides of
> it?

Lots.  The entire point of the ->interesting flag is to avoid fetching
additional details about tables that we don't really care about.
Unless I misunderstand, you're proposing throwing away that whole
optimization, which has got to be an overall loss.

			regards, tom lane