Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1vx5xF-00F9Kw-24
	for pgsql-bugs@arkaria.postgresql.org;
	Mon, 02 Mar 2026 16:17:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1vx5xE-001mM2-0M
	for pgsql-bugs@arkaria.postgresql.org;
	Mon, 02 Mar 2026 16:17:08 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vx5xD-001mLt-2l
	for pgsql-bugs@lists.postgresql.org;
	Mon, 02 Mar 2026 16:17:08 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vx5xC-000000002cN-2Qeh
	for pgsql-bugs@lists.postgresql.org;
	Mon, 02 Mar 2026 16:17:07 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 622GH337846353;
	Mon, 2 Mar 2026 11:17:03 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>,
        Virender Singla <virender.cse@gmail.com>,
        pgsql-bugs@lists.postgresql.org, Aniket Jha <aniketkumarj@gmail.com>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
In-reply-to: <CA+TgmoZmWg9FfHBLxw7vCJ7pkdWJtW6AMCUvoARTVYqcmeAW=w@mail.gmail.com>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql> <2939991.1740089974@sss.pgh.pa.us> <CA+TgmoauoiW4ydDhdrseg+DD4Kwha=+TSZp18BrJeHKx3o1Fdw@mail.gmail.com> <179448.1772033773@sss.pgh.pa.us> <CA+TgmoYFc1x11Y7AHxn6Jb0mvJ9-aPttmjqezj=YKnHmqVb-Wg@mail.gmail.com> <265501.1772038216@sss.pgh.pa.us> <CA+TgmobNKFc34nj+w6iX0zWJ1=mfYWqQS91PqsJrm4VD4o1yOw@mail.gmail.com> <296083.1772041154@sss.pgh.pa.us> <CA+TgmoYJ8Y1G1r9U7pRwnyw=8dmM0xygLguE+bdihkN8GwPuCQ@mail.gmail.com> <301798.1772044229@sss.pgh.pa.us> <CA+TgmobZRL02-R7k_i3ENYz8CmqCPUZv6cHY51BejqPy7OhFJw@mail.gmail.com> <304751.1772045891@sss.pgh.pa.us> <1103272.1772227345@sss.pgh.pa.us> <1104379.1772227731@sss.pgh.pa.us> <CA+TgmobMUVTj=5csi-vT=w731H5PBj+0SpCS_AndZEv_eum-jA@mail.gmail.com> <1106526.1772229127@sss.pgh.pa.us> <CA+TgmoZmWg9FfHBLxw7vCJ7pkdWJtW6AMCUvoARTVYqcmeAW=w@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Mon, 02 Mar 2026 09:19:29 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <846351.1772468223.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Mon, 02 Mar 2026 11:17:03 -0500
Message-ID: <846352.1772468223@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: <https://www.postgresql.org/message-id/846352.1772468223%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Feb 27, 2026 at 4:52 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Fair ... do you have a suggestion for less confusing names?
>> I considered naming the new variable "dump_this_grantor", but thought
>> it was longer without being more helpful ... but maybe you disagree.

> Personally, I'd find the extra verbosity helpful, but I don't care
> that much if you see it otherwise.

If you think that's better, I'm happy to make it so.  An author is
seldom the best judge of readability of his code.

Pushed like that.

			regards, tom lane