From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Hamid Akhtar <hamid.akhtar@gmail.com>,
        Simon Riggs <simon.riggs@enterprisedb.com>, pgsql-bugs@postgresql.org
Subject: Re: Bug in error reporting for multi-line JSON
In-reply-to: <01F48B70-5CAA-4922-B900-80E49A2D8488@yesql.se>
References: 
 <CANbhV-EPBnXm3MF_TTWBwwqgn1a1Ghmep9VHfqmNBQ8BT0f+_g@mail.gmail.com>
 <914794.1611252508@sss.pgh.pa.us>
 <CANbhV-FJk_+XTcnuuxujP2FUi7qwC=sUUyEBcbqYoOWmZhxD4A@mail.gmail.com>
 <CANugjhuR8U+uzSptTZ7tEUGvCt8vGnSz89rRw+89yd+wx_nLvA@mail.gmail.com>
 <CANugjhsOvEk9OJ4b1Y3CxC9A8GwHt-cRU1-ymiod859En833-Q@mail.gmail.com>
 <01F48B70-5CAA-4922-B900-80E49A2D8488@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Mon, 01 Mar 2021 15:04:40 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <849056.1614635401.1@sss.pgh.pa.us>
Date: Mon, 01 Mar 2021 16:50:01 -0500
Message-ID: <849057.1614635401@sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> I'm changing the status of this patch to Ready for Committer.

I reviewed this and pushed it, with some changes.

I noted that there was a basically unused "line_start" field in
JsonLexContext, which seems clearly to have been meant to track
what the new field was going to track.  So we can fix this without
any new field by updating that at the right times.

I thought putting jsonb tests into json.sql was a bit poorly
thought out.  I ended up adding parallel tests to both json.sql
and jsonb.sql ... maybe that's overkill, but a lot of the rest
of those scripts is duplicative too.  The tests weren't exercising
the dots-at-start-of-line behavior, either.

			regards, tom lane