From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
cc: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>,
        "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
        Duncan Sands <duncan.sands@deepbluecap.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: Logical replication 'invalid memory alloc request size
 1585837200' after upgrading to 17.5
In-reply-to: 
 <CAD21AoBfFEG=y=sHrhOO-EWpcFW=PmXcFhkPGYF+O0AH+bRo6w@mail.gmail.com>
References: <680bdaf6-f7d1-4536-b580-05c2760c67c6@deepbluecap.com>
 <CAA4eK1JwJw6JOnfDxtGtSRF7kM0LbEVPRmNxWeJa5+wyoG05Xg@mail.gmail.com>
 <CAA4eK1LMgqeT_bPZ3MH-VKvwOqpZyfJmF7knZhu1rqt2Pqsnwg@mail.gmail.com>
 <CAD21AoCjpj-DoASrhKCiEKuxh=0q3rC1RnAeugEwEJ=xwk=n6g@mail.gmail.com>
 <CAA4eK1LVcHD6VpH7m=8F9ru7Qdj9hsXE0gXtS93RmtTxf6L1NA@mail.gmail.com>
 <CAD21AoCeM2nni1P7Z6KXzLM=6zCdShC82sOvuvu0_hBuJkm9Qw@mail.gmail.com>
 <OS7PR01MB14968B3C263074A2DEB77DB58F565A@OS7PR01MB14968.jpnprd01.prod.outlook.com>
 <CAA4eK1+PGTdkTJwK8Necq8GrAJWP4T8cp_ponzbtogkFYvbK2w@mail.gmail.com>
 <CAD21AoCUJ=hvM=VDcH-Po=_spfyDwenniXEcgkiZU2xc4FJdJQ@mail.gmail.com>
 <CAA4eK1LqTcH5vYrCUFn=NUHv_9eYrZS6piLA3UUKD4=39xB=fQ@mail.gmail.com>
 <CAD21AoAAmGhA6NCWq=P-fzOxi4WZQCoN0y2_UOug+CMJL=YZPA@mail.gmail.com>
 <CAA4eK1LYsYCx1SNMid-4EgfYvBtxMbVvWC4q7NM7rLfyPz5GzQ@mail.gmail.com>
 <CAD21AoBDDGkHLryP1TJeh9QM3DB5ipLLThGfC6P_mk_bsxSA8A@mail.gmail.com>
 <CALDaNm0f=LgfQiV3oM3_4LOZrdLSSw8-+kUFvYNmxt4PYZymxw@mail.gmail.com>
 <CAA4eK1J8_!
 iazK=3G76Wq6pFe+LW6FYwBOmz82Y1JTpJ8Ca1YLg@mail.gmail.com>
 <CALDaNm1-RXLA_6y_o1=j5Borz9kGapyimN=6jDbx1nDCmQzjGQ@mail.gmail.com>
 <CAD21AoCPJS3=SY28X5X_sfKzMA8PU3y0nm16ReyboFdX8=gRfg@mail.gmail.com>
 <CALDaNm0iqYWveBLwGSgyn5WZQ7F-hjPNtxLtctUi=Oa=-jTHDw@mail.gmail.com>
 <CALDaNm2sGfKsZwm8rG132N_i0AvyxkYu8TL46kNcx7KwAUABxA@mail.gmail.com>
 <CAD21AoAX6sLVFz2bzDEuHP8mRpHEEmwpt88S4=FD1k_+fynLHg@mail.gmail.com>
 <CALDaNm21OWoL66qpgVEsv0ZvgDLaiVkjtcU-YDVqQZVvo3NNPA@mail.gmail.com>
 <CAD21AoBhDBqavSkxr+0GCxom1Q7P7guY5Ees20Wda=YZLFVfCA@mail.gmail.com>
 <OSCPR01MB149664746A441DE1F9F56203DF56CA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAD21AoAvZ=8_in4NcdXcOWaHnBdch_R5NE7N+iOde2+7S2QuDw@mail.gmail.com>
 <OSCPR01MB14966456C004EB65B31FE72AAF56FA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAD21AoCR5ULReGxM9VNsp91MamPYLNLM7oiWqizpb-gPSpicVg@mail.gmail.com>
 <CAA4eK1JVQfYKF8TfDuoZpQYRXq7siVn5k_4u270FMVGth1V_bw@mail.gmail.com>
 <CAD21AoCNNkLPoc+PWLGpZs74NwHxCvvffAjx6Yn3pJ2xJJPWtw@mail.gmail.com> <CALD!
 aNm0DkWbr8eA3kAkEw+cZA-n=KPmFxZ_5bz_YDqhYQGk6iA@mail.gmail.com>
 <CALDaNm0TaTPuza7Fa+DRMzL+mqK3+7RVEvFiRoDJbU2vkJESwg@mail.gmail.com>
 <CAD21AoDRkvBQdFtHfro2zd7HxcCT4JSWGWfF68YU977mvu6oVg@mail.gmail.com>
 <CAD21AoDCphZ30iiMOG8mZH_eo40m_1KY=4gz7-Yd+9M3FRBySg@mail.gmail.com>
 <CALDaNm3m6Dq2d6bCBaOjnABYavT3p+=VbJd5oJKok0sCTOSZog@ma
Comments: In-reply-to Masahiko Sawada <sawada.mshk@gmail.com>
	message dated "Tue, 17 Jun 2025 10:40:36 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <857721.1750738725.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 24 Jun 2025 00:18:45 -0400
Message-ID: <857722.1750738725@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/857722.1750738725%40sss.pgh.pa.us>
Precedence: bulk

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> Pushed the fix (d87d07b7ad3). Thank you for working on this fix.

There is something not right about the v13 version of this patch.
BF member trilobite, which builds with -DCLOBBER_CACHE_ALWAYS,
is showing this failure [1]:

diff -U3 /home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/con=
trib/test_decoding/expected/invalidation_distribution.out /home/buildfarm/=
trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/test_decoding/output=
_iso/results/invalidation_distribution.out
--- /home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/=
test_decoding/expected/invalidation_distribution.out	2025-06-17 10:24:24.3=
82768613 +0200
+++ /home/buildfarm/trilobite/buildroot/REL_13_STABLE/pgsql.build/contrib/=
test_decoding/output_iso/results/invalidation_distribution.out	2025-06-17 =
15:01:53.921913314 +0200
@@ -31,7 +31,7 @@
 step s2_get_binary_changes: SELECT count(data) FROM pg_logical_slot_get_b=
inary_changes('isolation_slot', NULL, NULL, 'proto_version', '1', 'publica=
tion_names', 'pub') WHERE get_byte(data, 0) =3D 73;
 count
 -----
-    0
+    1
 (1 row)

I can reproduce that locally if I add -DCLOBBER_CACHE_ALWAYS.
Have not looked for the cause.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dtrilobite&dt=
=3D2025-06-17%2008%3A24%3A00