From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18546: Attempt to insert default into a non-updatable column
 of a view fails with a dubious error
In-reply-to: 
 <CAEZATCWLfKrE7m0pNMD3-5GCk=swfZWUMmatvHqDPMO9KNa3Vg@mail.gmail.com>
References: <18546-84a292e759a9361d@postgresql.org>
 <320614.1721492789@sss.pgh.pa.us>
 <CAEZATCWLfKrE7m0pNMD3-5GCk=swfZWUMmatvHqDPMO9KNa3Vg@mail.gmail.com>
Comments: In-reply-to Dean Rasheed <dean.a.rasheed@gmail.com>
	message dated "Mon, 22 Jul 2024 09:41:11 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <868879.1721658681.1@sss.pgh.pa.us>
Date: Mon, 22 Jul 2024 10:31:21 -0400
Message-ID: <868880.1721658681@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/868880.1721658681%40sss.pgh.pa.us>
Precedence: bulk

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> I had always thought that rewriteTargetListIU() only ever added or
> merged items, somehow overlooking the fact that it could also delete
> them. In my defence, it's very easy to get that impression just by
> reading the function's comments. I think it's worth updating those
> comments to mention that. Something like the attached, perhaps.

No objection here.

			regards, tom lane