From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: "Haifang Wang (Centific Technologies Inc)" <v-haiwang@microsoft.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: [EXTERNAL] Re: Windows Application Issues | PostgreSQL | REF #
 48475607
In-reply-to: 
 <CA+hUKG+GUcSzk7UwvuLr4p84BQV8k2xvVAjToW=fQ5rCrciJ4A@mail.gmail.com>
References: 
 <PH8PR21MB390263C479B81A1B7330E744E5182@PH8PR21MB3902.namprd21.prod.outlook.com>
 <PH8PR21MB3902F334A3174C54058F792CE5182@PH8PR21MB3902.namprd21.prod.outlook.com>
 <CA+hUKG+b_XqMZ6xkFhMCEwLXbGSN1rDYYY-En8MgFe81auRAAg@mail.gmail.com>
 <PH8PR21MB39022E5B54CE6E03E194B30FE5E22@PH8PR21MB3902.namprd21.prod.outlook.com>
 <CA+hUKGKrzGnCW3MoVC7gayHCtJQPEJKgpfQWD6c7eUvFp+ac+A@mail.gmail.com>
 <PH8PR21MB39027F1F4EAFEAE33EB4BA39E5E22@PH8PR21MB3902.namprd21.prod.outlook.com>
 <CA+hUKG+GUcSzk7UwvuLr4p84BQV8k2xvVAjToW=fQ5rCrciJ4A@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Tue, 14 May 2024 10:47:23 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <872238.1715641638.1@sss.pgh.pa.us>
Date: Mon, 13 May 2024 19:07:18 -0400
Message-ID: <872239.1715641638@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/872239.1715641638%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Longer term I'm looking for something better than that though, because
> it doesn't address the root cause (need for stable identifiers), and
> will only ever allow us to fix problems with the old unstable names
> *after* users complain that their database is dead, 3-6 months after
> in fact due to release cycles.  I think a dynamic mapping file might
> be better?  (Maybe win32locale.c should be able to read that kludge
> table from a file that you can give it with an environment variable,
> or something like that?)

+1 for the long-term solution being more-stable locale identifiers.
However, we should try to build something that will let users get
out of these situations with the existing identifiers, so I like
your idea of a plain-text mapping file for Windows locale names.
I don't think an environment variable is necessary; just define
a fixed name "$PGDATA/locale_map.txt" or such.  If that file
exists, just read it and map the pg_database field values with it.

Maybe this shouldn't even be Windows-specific?  Are there any
cases where it'd save people's bacon on other platforms?

			regards, tom lane