Message-ID: <873d332a-9609-4a1a-bb01-0344e2542575@oss.nttdata.com>
Date: Wed, 2 Jul 2025 17:44:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #16931: source code problem about commit_ts
Content-Language: en-US
To: Andy Fan <zhihuifan1213@163.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, zoulx1982@163.com,
 pgsql-bugs@lists.postgresql.org
References: <20210409224241.GA32072@alvherre.pgsql>
 <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
 <87ecuzmkqf.fsf@163.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <87ecuzmkqf.fsf@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/873d332a-9609-4a1a-bb01-0344e2542575%40oss.nttdata.com>
Precedence: bulk


On 2025/07/02 10:42, Andy Fan wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> 
> Hi,
> 
>> On 2021/04/10 7:42, Alvaro Herrera wrote:
>>> On 2021-Mar-24, Fujii Masao wrote:
>>>
>>>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>>>> index 7ebd3d35ef..26bad44b96 100644
>>>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>>>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>>>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>>>    		appendStringInfo(buf, "pageno %d, oldestXid %u",
>>>>    						 trunc->pageno, trunc->oldestXid);
>>>>    	}
>>>> -	else if (info == COMMIT_TS_SETTS)
>>> You have not pushed this one, right?  I think we should do it now.
>>
>> Thanks for the ping! Pushed!
> 
> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
> remove struct xl_commit_ts_set?

You're right. I seem to have overlooked that.


> After it, there is no reference to
> xl_commit_ts_set. So Is it better clean them as well?

Agreed, the patch looks good to me. Unless there are objections,
I'll go ahead and commit it. While this could be considered an oversight
in the original commit, it's not a bug fix, so I plan to apply it
only to the master branch.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation