Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1izB4J-0006Gd-1p
	for pgsql-bugs@arkaria.postgresql.org; Wed, 05 Feb 2020 03:09:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1izB4G-0006Dc-Oo
	for pgsql-bugs@arkaria.postgresql.org; Wed, 05 Feb 2020 03:09:32 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1izB4G-0006DC-8Y
	for pgsql-bugs@lists.postgresql.org; Wed, 05 Feb 2020 03:09:32 +0000
Received: from lungold.riddles.org.uk ([82.68.208.19])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1izB4D-00065x-2L
	for pgsql-bugs@lists.postgresql.org; Wed, 05 Feb 2020 03:09:31 +0000
Received: from [192.168.127.1] (port=46186 helo=caithnard.riddles.org.uk)
	by lungold.riddles.org.uk with esmtp (Exim 4.92.3 (FreeBSD))
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1izB48-0005oZ-Kx; Wed, 05 Feb 2020 03:09:24 +0000
Received: from localhost ([127.0.0.1]:60446 helo=caithnard.riddles.org.uk)
	by caithnard.riddles.org.uk with esmtp (Exim 4.92.3 (FreeBSD))
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1izB48-0002Ak-8R; Wed, 05 Feb 2020 03:09:24 +0000
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Vik Fearing <vik@postgresfriends.org>
Cc: Andres Freund <andres@anarazel.de>,  pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16242: convert_tuple_* not handling missing values correctly
In-Reply-To: <5e0747c0-68af-c937-b8f7-c11b12126d7a@postgresfriends.org> (Vik
	Fearing's message of "Wed, 5 Feb 2020 03:38:06 +0100")
Message-ID: <878slhohmw.fsf@news-spur.riddles.org.uk>
References: <16242-d1c9fca28445966b@postgresql.org>
	<31edb400-f065-73c4-7b1f-2953ad3413e6@postgresfriends.org>
	<20200205021933.c4wtkpcx2li3um2k@alap3.anarazel.de>
	<3c396c9e-960f-9c03-63b7-d58e0e044fba@postgresfriends.org>
	<20200205022634.77y7fg7vyhn2svh7@alap3.anarazel.de>
	<5e0747c0-68af-c937-b8f7-c11b12126d7a@postgresfriends.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix)
Date: Wed, 05 Feb 2020 03:09:24 +0000
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

>>>>> "Vik" == Vik Fearing <vik@postgresfriends.org> writes:

 Vik> Okay, here you go.

You should probably update the comments in the test case - regression
test comments shouldn't say they're going to fail unless that's the
expected result.

-- 
Andrew (irc:RhodiumToad)