From: Andy Fan <zhihuifan1213@163.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,  zoulx1982@163.com,
  pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
In-Reply-To: <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com> (Fujii
	Masao's message of "Mon, 12 Apr 2021 00:09:45 +0900")
References: <20210409224241.GA32072@alvherre.pgsql>
	<a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
Date: Wed, 02 Jul 2025 01:42:32 +0000
Message-ID: <87ecuzmkqf.fsf@163.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Archived-At: <https://www.postgresql.org/message-id/87ecuzmkqf.fsf%40163.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

Hi,

> On 2021/04/10 7:42, Alvaro Herrera wrote:
>> On 2021-Mar-24, Fujii Masao wrote:
>> 
>>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>>> index 7ebd3d35ef..26bad44b96 100644
>>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>>   		appendStringInfo(buf, "pageno %d, oldestXid %u",
>>>   						 trunc->pageno, trunc->oldestXid);
>>>   	}
>>> -	else if (info == COMMIT_TS_SETTS)
>> You have not pushed this one, right?  I think we should do it now.
>
> Thanks for the ping! Pushed!

Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
remove struct xl_commit_ts_set? After it, there is no reference to
xl_commit_ts_set. So Is it better clean them as well? 

typedef struct xl_commit_ts_set
{
	TimestampTz timestamp;
	RepOriginId nodeid;
	TransactionId mainxid;
	/* subxact Xids follow */
}			xl_commit_ts_set;

#define SizeOfCommitTsSet	(offsetof(xl_commit_ts_set, mainxid) + \

(When going through commit_ts.h, these code makes me think there is a
dedicated xlog for commit_ts, but the fact isn't, the commit_ts is
recorded in xl_xact_commit, removing dead code could be useful for such
case).

-- 
Best Regards
Andy Fan


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=v1-0001-Remove-xl_commit_ts_set.patch