From: Andy Fan <zhihuifan1213@163.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,  zoulx1982@163.com,
  pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
In-Reply-To: <873d332a-9609-4a1a-bb01-0344e2542575@oss.nttdata.com> (Fujii
	Masao's message of "Wed, 2 Jul 2025 17:44:30 +0900")
References: <20210409224241.GA32072@alvherre.pgsql>
	<a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
	<87ecuzmkqf.fsf@163.com>
	<873d332a-9609-4a1a-bb01-0344e2542575@oss.nttdata.com>
Date: Thu, 03 Jul 2025 13:33:27 +0000
Message-ID: <87jz4p9z6g.fsf@163.com>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/87jz4p9z6g.fsf%40163.com>
Precedence: bulk

Fujii Masao <masao.fujii@oss.nttdata.com> writes:

>>>
>>> Thanks for the ping! Pushed!
>> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
>> remove struct xl_commit_ts_set?
>
> You're right. I seem to have overlooked that.
>
>> After it, there is no reference to
>> xl_commit_ts_set. So Is it better clean them as well?
>
> Agreed, the patch looks good to me. Unless there are objections,
> I'll go ahead and commit it.

Thank you Fujii!

> While this could be considered an oversight in the original commit,
> it's not a bug fix, so I plan to apply it only to the master branch. 

That makes sense to me.

-- 
Best Regards
Andy Fan