From: Sam James <sam@gentoo.org>
To: pgsql-bugs@lists.postgresql.org
Subject: Build failure with GCC 15 (defaults to -std=gnu23)
Organization: Gentoo
User-Agent: mu4e 1.12.7; emacs 31.0.50
Date: Sun, 17 Nov 2024 02:54:01 +0000
Message-ID: <87o72eo9iu.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/87o72eo9iu.fsf%40gentoo.org>
Precedence: bulk

Hi,

postgres-17.1 fails to build with upcoming GCC 15 which defaults to
-std=gnu23 as follows:
```
In file included from ../../src/include/postgres_fe.h:25,
                 from checksum_helper.c:17:
../../src/include/c.h:456:23: error: two or more data types in declaration specifiers
  456 | typedef unsigned char bool;
      |                       ^~~~
../../src/include/c.h:456:1: warning: useless type name in empty declaration
  456 | typedef unsigned char bool;
      | ^~~~~~~
```

src/include/c.h does attempt to check for whether bool is already defined but
the check doesn't work.

There may be more issues afterwards but I haven't tried papering over
the above issue. It should be possible to reproduce w/
CFLAGS="... -std=gnu23" or CFLAGS="... -std=c23" on older GCC or Clang.

thanks,
sam