Content-Type: multipart/alternative;
 boundary="------------zKTqauvNTm17hivtsUGXONku"
Message-ID: <8877ae08-5dcd-45bf-8475-c6d5a5200346@dunslane.net>
Date: Fri, 13 Dec 2024 08:48:04 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
To: Robins Tharakan <tharakan@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Thomas Munro
 <thomas.munro@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
 Sam James <sam@gentoo.org>, pgsql-bugs@lists.postgresql.org
References: <485f5982-18c5-4210-9c7d-7c05453f7033@eisentraut.org>
 <CA+hUKGL0LWK7hVO9r2eb3hFDBptZByOkAKGAjXKJ5mqd9hs_fA@mail.gmail.com>
 <1447160.1732565223@sss.pgh.pa.us>
 <CA+hUKG+5ErSyS2+rqx0bvKAWadP9NQBOsUgZVpz74ZB0DA=nJw@mail.gmail.com>
 <1578470.1732587191@sss.pgh.pa.us>
 <CA+hUKGJ4HEntEJkpqinyaLn3AfXMvCirWk0n2H4LWDxSSGh-Dw@mail.gmail.com>
 <CA+hUKG+y2q0dP=g=bbkAWD66unrSKsQEc29ERvA_6fTC3b954Q@mail.gmail.com>
 <1897695.1732732104@sss.pgh.pa.us>
 <eu34f6armrlbq7cdai3dy45576h3qybme47uxens4cowpghzqe@52owmagijfiu>
 <2gao2zapw2dumahxgma4t3c6cquy4vnjs5bt4yvduexpywwm2m@3uhxxc63xvlq>
 <CAEP4nAw4UHSgcHFL7Rsub0nCHW=6ZCrpiuBUT_dV5+4apS=Q5Q@mail.gmail.com>
 <494522.1732894313@sss.pgh.pa.us>
 <CAEP4nAyRfWZ8T8xzNHHy4p8kLCrXAAY7Hbs2_P8YCOJiu=6SCA@mail.gmail.com>
 <970389.1734052913@sss.pgh.pa.us>
 <CAEP4nAyOKW+CLHrFDHw1e6fjEG+urL2x1DSeFiU8vnaGsOrV1g@mail.gmail.com>
 <CAEP4nAzOaY0PR-7_t6aN-Dwq6vZzO3i0JAAx2BBRUzy3LwtNGw@mail.gmail.com>
 <CAEP4nAxMtdyj7xtrf_fPNj8qU0bprOR=fDiCc154_UhQyUZ5cA@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: 
 <CAEP4nAxMtdyj7xtrf_fPNj8qU0bprOR=fDiCc154_UhQyUZ5cA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/8877ae08-5dcd-45bf-8475-c6d5a5200346%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------zKTqauvNTm17hivtsUGXONku
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024-12-12 Th 9:31 PM, Robins Tharakan wrote:
>
> On Fri, 13 Dec 2024 at 12:46, Robins Tharakan <tharakan@gmail.com> wrote:
>
>
>     REL_17_STABLE failed on misc-recovery and one context I can add
>     here is
>     that I triggered both REL_16_STABLE and REL_17_STABLE together and
>     were running neck-and-neck wherein v16 went past this test (in ~4
>     minutes)
>     and v17 (got stuck for ~10 min) and failed.
>
>
> Is it possible that 2 concurrent runs (of different branches) could 
> step on each other?
>
> These are the logs that I captured, and v16 [2] / v17 [1] literally 
> ran at the same
> time (seconds apart).
>
>
> v16 log:
> alligator:REL_16_STABLE [12:24:42] running bin test scripts ...
> alligator:REL_16_STABLE [12:25:28] running test misc-recovery ...
> alligator:REL_16_STABLE [12:29:40] running test misc-subscription ...
>
>
> v17 log:
> alligator:REL_17_STABLE [12:25:09] running bin test psql ...
> alligator:REL_17_STABLE [12:25:19] running bin test scripts ...
> alligator:REL_17_STABLE [12:26:00] running test misc-recovery ...
> alligator:REL_17_STABLE [12:37:15] failed at stage recoveryCheck
> $
>

We actually have a good deal of protection against concurrent runs 
clobbering each other.

It's not clear to me if you're using "run_branches.pl --run-parallel" or 
not. If not, you might like to consider changing to that - it's the 
recommended way of doing concurrent runs. Apart from any other reason it 
removes the need for a lot of redundant git fetches. By default it 
staggers concurrent build starts by 60 seconds.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------zKTqauvNTm17hivtsUGXONku
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2024-12-12 Th 9:31 PM, Robins
      Tharakan wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAEP4nAxMtdyj7xtrf_fPNj8qU0bprOR=fDiCc154_UhQyUZ5cA@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr">
          <div><br>
          </div>
        </div>
        <div class="gmail_quote gmail_quote_container">
          <div dir="ltr" class="gmail_attr">On Fri, 13 Dec 2024 at
            12:46, Robins Tharakan &lt;<a
              href="mailto:tharakan@gmail.com" moz-do-not-send="true"
              class="moz-txt-link-freetext">tharakan@gmail.com</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div dir="ltr">
              <div dir="ltr">
                <div><br>
                </div>
              </div>
              <div class="gmail_quote">
                <div>REL_17_STABLE failed on misc-recovery and one
                  context I can add here is</div>
                <div>that I triggered both REL_16_STABLE and
                  REL_17_STABLE together and</div>
                <div>were running neck-and-neck wherein v16 went past
                  this test (in ~4 minutes)</div>
                <div>and v17 (got stuck for ~10 min) and failed.</div>
                <div><br>
                </div>
              </div>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>Is it possible that 2 concurrent runs (of different
            branches) could step on each other?</div>
          <div><br>
          </div>
          <div>These are the logs that I captured, and v16 [2] / v17 [1]
            literally ran at the same</div>
          <div>time (seconds apart).</div>
          <div><br>
          </div>
          <div><br>
          </div>
          <div>v16 log:</div>
        </div>
        <div class="gmail_quote gmail_quote_container">alligator:REL_16_STABLE
          [12:24:42] running bin test scripts ...</div>
        <div class="gmail_quote gmail_quote_container">alligator:REL_16_STABLE
          [12:25:28] running test misc-recovery ...<br>
          alligator:REL_16_STABLE [12:29:40] running test
          misc-subscription ...<br>
          <br>
          <br>
          v17 log:<br>
          alligator:REL_17_STABLE [12:25:09] running bin test psql ...<br>
          alligator:REL_17_STABLE [12:25:19] running bin test scripts
          ...<br>
          alligator:REL_17_STABLE [12:26:00] running test misc-recovery
          ...<br>
          alligator:REL_17_STABLE [12:37:15] failed at stage
          recoveryCheck<br>
          $<br>
          <div><br>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>We actually have a good deal of protection against concurrent
      runs clobbering each other. <br>
    </p>
    <p>It's not clear to me if you're using "run_branches.pl
      --run-parallel" or not. If not, you might like to consider
      changing to that - it's the recommended way of doing concurrent
      runs. Apart from any other reason it removes the need for a lot of
      redundant git fetches. By default it staggers concurrent build
      starts by 60 seconds.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------zKTqauvNTm17hivtsUGXONku--