Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j3khN-0002NI-RM for pgsql-bugs@arkaria.postgresql.org; Mon, 17 Feb 2020 18:00:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j3kgN-0002SV-MQ for pgsql-bugs@arkaria.postgresql.org; Mon, 17 Feb 2020 17:59:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j3kgN-0002SO-Al for pgsql-bugs@lists.postgresql.org; Mon, 17 Feb 2020 17:59:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3kgG-0008Cf-Mx for pgsql-bugs@lists.postgresql.org; Mon, 17 Feb 2020 17:59:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01HHxbQO008933; Mon, 17 Feb 2020 12:59:37 -0500 From: Tom Lane To: Marc Munro cc: pgsql-bugs@lists.postgresql.org Subject: Re: pg_dump No comment for policy In-reply-to: <1581889298.18009.15.camel@bloodnok.com> References: <1581889298.18009.15.camel@bloodnok.com> Comments: In-reply-to Marc Munro message dated "Sun, 16 Feb 2020 13:41:38 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8931.1581962377.1@sss.pgh.pa.us> Date: Mon, 17 Feb 2020 12:59:37 -0500 Message-ID: <8932.1581962377@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Marc Munro writes: > I have created a policy with a comment on it. pg_dump does not dump > the comment. Ugh, yeah, there's no dumpComment() call in dumpPolicy(). Easy enough to fix, but now I wonder if we missed the same elsewhere. regards, tom lane