Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m13B5-0005k1-QG for pgsql-bugs@arkaria.postgresql.org; Wed, 07 Jul 2021 08:45:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m13B4-0007Fy-Ox for pgsql-bugs@arkaria.postgresql.org; Wed, 07 Jul 2021 08:45:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m13B4-0007Fp-Hv for pgsql-bugs@lists.postgresql.org; Wed, 07 Jul 2021 08:45:06 +0000 Received: from forward1-smtp.messagingengine.com ([66.111.4.223]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m13B0-00006g-AU for pgsql-bugs@lists.postgresql.org; Wed, 07 Jul 2021 08:45:06 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.nyi.internal (Postfix) with ESMTP id 4AA671940913; Wed, 7 Jul 2021 04:45:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 07 Jul 2021 04:45:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=+V0Uu95/S/1kRnDNE3pExf/e2v9cJYRlJ5XI+tXCv /Y=; b=eJNThwSBwYzh6tByLU+zCqOV/7zOG7HIqFw8or/o/GPEUC+KGuPs4yZaK oRLKNAuXR//3PysCuS+Y+s1LPrZmW/gBJpQPFokYuLI6KCWlPzvyj4QgiqrpfCMa BfeHX17xznztgiDJwmpdfUE1c+cnTtuUWV54n6P+O6eQBVR2zmCOEgNyllhUEUKH fakZCMD+pX16V2+PVAGEtfYjg8+l9yq3JB2qADvJurQr2Dxe8WalXHVLuiAucJDk BZCzYngU9t4nESWpW2rLcQwyKl5O+t0b6Nk7jHTzwN7bhnCYLKWZuTpw47fQxzu0 Qs4uK/xeW22wcnljlN23HZy000gyw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtddvgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrh hprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelveehheeuieduieetiedt keeuteelfeetjeffieffudegvdffvdfftdeivdeukeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghuthes vghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jul 2021 04:44:59 -0400 (EDT) Subject: Re: BUG #16631: postgres_fdw tries to insert into generated columns To: Etsuro Fujita , dacherny@gmail.com, PostgreSQL mailing lists References: <16631-e929fe9db0ffc7cf@postgresql.org> From: Peter Eisentraut Message-ID: <8a61d9c4-b614-e2dc-6bcc-bfc17db4d2f9@enterprisedb.com> Date: Wed, 7 Jul 2021 10:44:58 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 07.07.21 09:20, Etsuro Fujita wrote: > * Modified nodeModifyTable.c and copyfrom.c so that they don't compute > generated columns for FDWs anymore. I don't agree with that change. What is the point of declaring a generated column on a foreign table if you ignore it? Then you might as well prohibit declaring such columns in the first place.