Message-ID: <8bc21242-6a7c-47b3-5af1-e6c9956d5ffa@pgmasters.net>
Date: Tue, 26 Jul 2022 07:33:09 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: could not link file in wal restore lines
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: zsolt.ero@gmail.com, pgsql-bugs@lists.postgresql.org, michael@paquier.xyz
References: 
 <CAKw-smA-0yhaJJQxqjmYn+dMzLmWoCbwiS7P5jeKe5DjzvM2xA@mail.gmail.com>
 <4b392ab1-d4a5-5557-adf0-ae319e723da5@pgmasters.net>
 <20220726.114814.306729894656662536.horikyota.ntt@gmail.com>
 <20220726.150311.891076428649612904.horikyota.ntt@gmail.com>
From: David Steele <david@pgmasters.net>
In-Reply-To: <20220726.150311.891076428649612904.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8bc21242-6a7c-47b3-5af1-e6c9956d5ffa%40pgmasters.net>
Precedence: bulk

On 7/26/22 02:03, Kyotaro Horiguchi wrote:
> At Tue, 26 Jul 2022 11:48:14 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
>> Ah, sorry for posting following too-early messages in the thread.
>>
>> At Mon, 25 Jul 2022 08:40:12 -0400, David Steele <david@pgmasters.net> wrote in
>>> Your system seems to be doing recovery pretty quickly. I wonder if
>>> there is a race condition in WAL recycling?
> 
> And it has been fixed by cc2c7d65fc in PG15.  That discussion [1]
> concluded that we don't back-patch it.
> 
> [1] https://www.postgresql.org/message-id/flat/20210202151416.GB3304930%40rfd.leadboat.com
>> Does anyone prefer some alternative?  It's probably not worth
>> back-patching anything for a restartpoint failure this rare, because
>> most restartpoint outcomes are not user-visible.

I have responded on that thread to see if Noah can have a look and 
decide if it would be worth back-patching cc2c7d65fc.

There have been other changes in this area (e.g. removing 
durable_rename_excl) so it would be good to know if back-patching just 
cc2c7d65fc will work.

Kyotaro, since you can reproduce the issue would you be willing to test 
that?

Regards,
-David