From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Andrew Dunstan <andrew@dunslane.net>, Peter Geoghegan <pg@bowt.ie>,
        Robert Haas <robertmhaas@gmail.com>,
        Pavel Borisov <pashkin.elfe@gmail.com>,
        Alexander Lakhin <exclusion@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: BUG #17212: pg_amcheck fails on checking temporary relations
In-reply-to: <02C6345B-D186-4F88-A976-A2CD1051CB93@enterprisedb.com>
References: <17212-34dd4a1d6bba98bf@postgresql.org>
 <CA+TgmoYa5exExaONEnGBWRdi7A3=FKuKzewY8DXTj6+045wiFQ@mail.gmail.com>
 <CAH2-WzkwRUayddmb3uxCadV_y--DHfY+UMmjtOokiAO2xNh5fA@mail.gmail.com>
 <CA+Tgmoat1M4MAqUQM1H+bkWR=wXmi33bB0YRR=xaFk9ADs5Jeg@mail.gmail.com>
 <CAH2-Wzk3NzXYXsUKWBFuBm6aiXTh-_L2Dm9wPqfFenUvG+VbRw@mail.gmail.com>
 <543F3BF3-EDED-4C52-AF05-623921B6C409@enterprisedb.com>
 <CAH2-WzkXphRHgbaUXqMgb7SBmc_VbwdyWGYqphV6KbOH7stfxA@mail.gmail.com>
 <55A2BFE7-AAAF-4A64-BD3A-5C98EA982267@enterprisedb.com>
 <CAH2-WzniogVqNuWzNVLOKjkd8FBcSry29hN9=wiROUPw92fmGg@mail.gmail.com>
 <07159C9A-40DA-47BF-B2F4-! 203F5AC00890@enterprisedb.com>
 <CAH2-Wzkt-umhXfR1nqy=ZDXMfoN3LDK4W5VtchfWyRAuPWxtnA@mail.gmail.com>
 <40DB088B-C96F-49B2-BC84-BDC8D35C7E97@enterprisedb.com>
 <CAH2-Wzne7L9fX2LdZ9enNZpO2wuqbrsubCw2thH__CC_nZazjw@mail.gmail.com>
 <0B7DA7A4-2872-485B-BFDD-BF8E9BB07B26@enterprisedb.com>
 <726473.1634184950@sss.pgh.pa.us>
 <b5ec84db-c5af-bfac-fe4f-a704a364f90b@dunslane.net> <02C6345B-D186-4F!
 88-A976-A2CD1051CB93@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Thu, 14 Oct 2021 14:06:00 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <903679.1634246015.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 14 Oct 2021 17:13:35 -0400
Message-ID: <903680.1634246015@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/903680.1634246015%40sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> The pg_amcheck patch Peter committed for me adds a new test, src/bin/pg_=
amcheck/t/006_bad_targets.pl, which creates two PostgresNode objects (a pr=
imary and a standby) and uses PostgresNode::background_psql().  It doesn't=
 bother to "finish" the returned harness, which may be the cause of an ins=
tallation hanging around long enough to be in the way when another test tr=
ies to start.

(a) Isn't that just holding open one connection, not the whole instance?

(b) Wouldn't finish()ing that connection cause the temp tables to be
dropped, negating the entire point of the test?

TBH, I seriously doubt this test case is worth expending buildfarm
cycles on forevermore.  I'm more than a bit tempted to just drop
it, rather than also expending developer time figuring out why it's
not as portable as it looks.

			regards, tom lane