From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_D60C194E-2124-4C65-9701-BB2D2F819EB5"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\))
Subject: Re: BUG #16683: explain plan format xml produces invalid xml
Date: Fri, 23 Oct 2020 13:12:13 +0200
In-Reply-To: <16683-8005033324ad34e9@postgresql.org>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: jal@etc.to,
 PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
References: <16683-8005033324ad34e9@postgresql.org>
Precedence: bulk


--Apple-Mail=_D60C194E-2124-4C65-9701-BB2D2F819EB5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On 23 Oct 2020, at 12:26, PG Bug reporting form =
<noreply@postgresql.org> wrote:

> Sort-Space is incorrectly finished with /Sort-Spaces

Nice catch, it was introduced in the Incremental Sort patch, both for =
disk and
memory type sorts as per the attached (unless the opening of the group =
was
supposed to be "Sort Spaces" but singular seems the right choice here).=20=


cheers ./daniel


--Apple-Mail=_D60C194E-2124-4C65-9701-BB2D2F819EB5
Content-Disposition: attachment;
	filename=explain_sort_space.diff
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="explain_sort_space.diff"
Content-Transfer-Encoding: 7bit

diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
index 41317f1837..43f9b01e83 100644
--- a/src/backend/commands/explain.c
+++ b/src/backend/commands/explain.c
@@ -2827,7 +2827,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
 			ExplainPropertyInteger("Peak Sort Space Used", "kB",
 								   groupInfo->maxMemorySpaceUsed, es);
 
-			ExplainCloseGroup("Sort Spaces", memoryName.data, true, es);
+			ExplainCloseGroup("Sort Space", memoryName.data, true, es);
 		}
 		if (groupInfo->maxDiskSpaceUsed > 0)
 		{
@@ -2844,7 +2844,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
 			ExplainPropertyInteger("Peak Sort Space Used", "kB",
 								   groupInfo->maxDiskSpaceUsed, es);
 
-			ExplainCloseGroup("Sort Spaces", diskName.data, true, es);
+			ExplainCloseGroup("Sort Space", diskName.data, true, es);
 		}
 
 		ExplainCloseGroup("Incremental Sort Groups", groupName.data, true, es);

--Apple-Mail=_D60C194E-2124-4C65-9701-BB2D2F819EB5--