From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: julian.schauder@gmx.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15703: Segfault in cancelled CALL-Statements
In-reply-to: <8678.1553097373@sss.pgh.pa.us>
References: <15703-c12c5bc0ea34ba26@postgresql.org>
 <8678.1553097373@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 20 Mar 2019 11:56:13 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <9088.1553098021.0@sss.pgh.pa.us>
Date: Wed, 20 Mar 2019 12:07:47 -0400
Message-ID: <9112.1553098067@sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9088.1553098021.1@sss.pgh.pa.us>

I wrote:
> Poking around a bit, it seems like this is a thinko in HoldPinnedPortals:
> it's not considering the possibility of a failure during HoldPortal().
> In your test the failure is triggered by query cancel, but an ordinary
> execution error while finishing out a cursor's calculations would be
> a problem too.

Pursuant to which observation, here's a fully self-contained test case.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/plain; name="bug-15703-reproducer.sql";
	charset="us-ascii"
Content-ID: <9088.1553098021.2@sss.pgh.pa.us>
Content-Description: bug-15703-reproducer.sql

CREATE PROCEDURE crashme()
 LANGUAGE plpgsql
AS $procedure$
  DECLARE id_ int;
  BEGIN
    FOR id_ IN SELECT 1/(x-1000) from GENERATE_SERIES(1,1000) x LOOP
        COMMIT;
    END LOOP;
  END;
$procedure$;

call crashme();

------- =_aaaaaaaaaa0--