Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjhr-0003Fi-Gy for pgsql-bugs@arkaria.postgresql.org; Wed, 30 Sep 2020 21:32:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNjhq-0005ll-Dx for pgsql-bugs@arkaria.postgresql.org; Wed, 30 Sep 2020 21:32:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjhq-0005lY-84 for pgsql-bugs@lists.postgresql.org; Wed, 30 Sep 2020 21:32:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjho-0006Q4-3O for pgsql-bugs@lists.postgresql.org; Wed, 30 Sep 2020 21:32:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 08ULW4hJ911657; Wed, 30 Sep 2020 17:32:04 -0400 From: Tom Lane To: Henry Hinze cc: pgsql-bugs@lists.postgresql.org, Alvaro Herrera Subject: Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop In-reply-to: References: <16643-eaadeb2a1a58d28c@postgresql.org> <718213.1601410160@sss.pgh.pa.us> Comments: In-reply-to Henry Hinze message dated "Wed, 30 Sep 2020 12:44:56 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <911655.1601501524.1@sss.pgh.pa.us> Date: Wed, 30 Sep 2020 17:32:04 -0400 Message-ID: <911656.1601501524@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Henry Hinze writes: > I've made an important observation! > Since I had the impression this setup was already working with RC1 of PG > 13, I re-installed RC1 and did the same test. And it's working fine! Ugh. So that points the finger at commits 07082b08c/bfb12cd2b, which are the only nearby change between rc1 and 13.0. A quick comparison of before-and-after checkouts confirms it. After some digging around, I realize that that commit actually resulted in a protocol break. libpqwalreceiver is expecting to get an additional CommandComplete message after COPY OUT finishes, per libpqrcv_endstreaming(), and it's no longer getting one. (I have not read the protocol document to see if this is per spec; but spec or no, that's what libpqwalreceiver is expecting.) The question that this raises is how the heck did that get past our test suites? It seems like the error should have been obvious to even the most minimal testing. regards, tom lane