Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjlR-0003OP-G8 for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 21:35:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNjlQ-0007n9-EC for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 21:35:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjlQ-0007n1-7H for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2020 21:35:52 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjlK-0006SV-14 for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2020 21:35:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 08ULZhCU911842; Wed, 30 Sep 2020 17:35:43 -0400 From: Tom Lane To: Robert Haas cc: Bruce Momjian , "David G. Johnston" , Laurenz Albe , PostgreSQL Hackers Subject: Re: BUG #16419: wrong parsing BC year in to_date() function In-reply-to: References: <16419-d8d9db0a7553f01b@postgresql.org> <0123b852ae3fe53eca11b9451d035411b06dafd5.camel@cybertec.at> <20200904012149.GA13932@momjian.us> <20200904201224.GD6891@momjian.us> <663099.1601400389@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Wed, 30 Sep 2020 16:49:51 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <911840.1601501743.1@sss.pgh.pa.us> Date: Wed, 30 Sep 2020 17:35:43 -0400 Message-ID: <911841.1601501743@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Robert Haas writes: > On Tue, Sep 29, 2020 at 1:26 PM Tom Lane wrote: >> I think this is nuts. The current behavior is obviously broken; >> we should just treat it as a bug and fix it, including back-patching. >> I do not think there is a compatibility problem of any significance. >> Who out there is going to have an application that is relying on the >> ability to insert BC dates in this way? > I think that's entirely the wrong way to look at it. If nobody is > using the feature, then it will not break anything to change the > behavior, but on the other hand there is no reason to fix the bug > either. But if people are using the feature, making it behave > differently in the next minor release is going to break their > applications. I disagree *strongly* with making such changes in stable > branches and feel that the change to those branches should be > reverted. By that logic, we should never fix any bug in a back branch. regards, tom lane