Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kjCIy-0005ux-W0
	for pgsql-bugs@arkaria.postgresql.org; Sun, 29 Nov 2020 02:19:12 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kjCIS-0002Fe-DC
	for pgsql-bugs@arkaria.postgresql.org; Sun, 29 Nov 2020 02:18:40 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kjCIS-0002FW-7H
	for pgsql-bugs@lists.postgresql.org; Sun, 29 Nov 2020 02:18:40 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kjCIO-0001X1-0o
	for pgsql-bugs@lists.postgresql.org; Sun, 29 Nov 2020 02:18:39 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0AT2IWrx929681;
	Sat, 28 Nov 2020 21:18:32 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: kgradekx@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16746: [PG12.5 psql] Password ignored by connect
 meta-command
In-reply-to: 
 <CAKFQuwagfZ_KG-PbuTqCgKWOjELfDRLZrCvDiBSpZZqNgigK4Q@mail.gmail.com>
References: <16746-44b30e2edf4335d4@postgresql.org>
 <CAKFQuwagfZ_KG-PbuTqCgKWOjELfDRLZrCvDiBSpZZqNgigK4Q@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Sat, 28 Nov 2020 17:48:32 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <929679.1606616312.1@sss.pgh.pa.us>
Date: Sat, 28 Nov 2020 21:18:32 -0500
Message-ID: <929680.1606616312@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> Tom, will need your input here.

Ugh... looks like I broke this in 85c54287a et al.  I had thought that
this was the pre-existing behavior, but after further study I see that
I was mistaken about how PQconnectdbParams() handles parameter
replacement, so I misread what the prior code was really doing.

			regards, tom lane