Message-ID: <931f4e0a-5d1e-4ea6-86cf-807e8cd7c8e7@oss.nttdata.com>
Date: Thu, 12 Jun 2025 21:20:47 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #18952: pg_restore --help and document have strange
 description: Dump something
Content-Language: en-US
To: TAKATSUKA Haruka <harukat@sraoss.co.jp>
Cc: pgsql-bugs@lists.postgresql.org
References: <18952-be40a620f8b1e755@postgresql.org>
 <df4a3f45-3559-4fa0-9ae9-d1fbb1b4bb42@oss.nttdata.com>
 <20250611113807.d85d1f0abf413d49fb7c6398@sraoss.co.jp>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20250611113807.d85d1f0abf413d49fb7c6398@sraoss.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/931f4e0a-5d1e-4ea6-86cf-807e8cd7c8e7%40oss.nttdata.com>
Precedence: bulk


On 2025/06/11 11:38, TAKATSUKA Haruka wrote:
> On Wed, 11 Jun 2025 10:04:24 +0900
> Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> 
>> On 2025/06/10 16:35, PG Bug reporting form wrote:
>>> The following bug has been logged on the website:
>>>
>>> Bug reference:      18952
>>> Logged by:          TAKATSUKA Haruka
>>> Email address:      harukat@sraoss.co.jp
>>> PostgreSQL version: 18beta1
>>> Operating system:   any
>>> Description:
>>>
>>> pg_restore --help has strange description like "Dump .....":
>>> [dbhost]$ LANG=C pg_restore --help
>>> pg_restore restores PostgreSQL databases from archives created by pg_dump or
>>> pg_dumpall.
>>> Usage:
>>>     pg_restore [OPTION]... [FILE]
>>> (snip)
>>>     --with-data                  dump the data
>>>     --with-schema                dump the schema
>>>     --with-statistics            dump the statistics
>>> Connection options:
>>>     -h, --host=HOSTNAME      database server host or socket directory
>>> (snip)
>>> https://www.postgresql.org/docs/18/app-pgrestore.html also have the
>>> following description.
>>> --with-data
>>>       Dump data. This is the default.
>>> --with-schema
>>>       Dump schema (data definitions). This is the default.
>>> --with-statistics
>>>       Dump statistics. This is the default.
>>
>> Thanks for the report!
>>
>> Are you suggesting that "dump" in the help message and docs should be "restore"?
>> If so, does the attached patch address that correctly?
> 
> Yes.
> IMHO, if we take the intent of the commit bde2fb797aae, your patch is correct.

Okay, so if there are no objections, I'll go ahead and commit the patch.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation