Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xIzek-000000040al-2rfQ for pgsql-bugs@arkaria.postgresql.org; Tue, 20 Oct 2026 02:32:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xIzej-00000009uYP-2HgV for pgsql-bugs@arkaria.postgresql.org; Tue, 20 Oct 2026 02:32:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xIzej-00000009uYH-1Ehh for pgsql-bugs@lists.postgresql.org; Tue, 20 Oct 2026 02:32:49 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xIzeh-00000002tbt-2sWj for pgsql-bugs@lists.postgresql.org; Tue, 20 Oct 2026 02:32:48 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-2dd76b1361dso1941585ad.1 for ; Mon, 19 Oct 2026 19:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792463567; x=1793068367; darn=lists.postgresql.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jvWoezTjNjEWQUBDar1h8TZqv2vTBmsMRr3U6eT9/jw=; b=kBqR6wmL+i5k4nnDdwiBvEFVqZ5qMJfE/SPzmjbMN4efqsDyDNSYBK0ERIfjs5SbEE svSMWC9Azdl5nbiZbxeG9S8vIpMlYxxlzc4Rh2pmo8nBzqm8kphQ4yhtaAAQIPKVAFUV 7JVEzep238skWVCduz98Md/2fWEBGCjgLZZaWLXaj/66OdVkpu/IbVvtdy0VidaWNW5h 0RjoZ8n0UvQcjt+Flxuf0PdcUNgrVH/pP0/mb2wpyKW9TmH6bxy0ke3zht2zIms2S2iV /v7Bry7xZ6strSAsdw1k5D3ip/IP6/gcY7iyKgRZ+DCWNWBCz5EIwHycrkgkmU90/uXF rmwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792463567; x=1793068367; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jvWoezTjNjEWQUBDar1h8TZqv2vTBmsMRr3U6eT9/jw=; b=ve37mkEIyE3D+ntcLG+xIbKKpy5jDIOhsazGPO9ytP+VlJ/BMzEu6v9HfXa6r6wXPz gHAd0mfHpW+wRhfxV8iRHwRgU5icZIfkI//tPDys3veqj42jp0EEKEYiGjLLmc0y/9il I2VBL4ox0kJ5Mu+ZZ9FLFoFQg0ZSed94xwTsp2Ra2T0YXe+P5ZZflI4mq7164UgUXB+H ptdtZvhmlEMdMKB7SwM7IhHvfBuQ+d6PXdLaR4bPs/HQBkb4GJLwavJNP7VOWlrniG38 txLX724OTJb2YVOzOo02BSuZuixiLTI+djeiRwtw8gi+g4pflnb3JX2ai3itcX4Le+Re Bs4g== X-Forwarded-Encrypted: i=1; AKwUvBxr1feKnfzVX14Dscdm1t4QweV8R425Hj/yNHAv/D63K5LM8DPMfbZfGSy5mSanU7bhihpzAcJ8i/Ep@lists.postgresql.org X-Gm-Message-State: AFq9FYLVPzv0K3ij3/P3oGUTNXXe//P0iUMJRZp1ax0fW3RJrhgPIp4I LA7FlZNSoGz0Z88/2TsJwsUC43/Hfh6kRvKbzBWs9Tv3pEw9VuJSxbuV X-Gm-Gg: AYBFou10knEKWdqZa4GlkZ+VkCgE+7TBRVY4mDbv61hTHkgV89nOYGrNrb69tNKLrJO 6xqvj7e8d0BEmtYlVM4l2DsGTAUikX4+uZuoUQTrDPxMOLjyzohLRHZLIbkCrPMTBRNjD5UNraG jV412DW+dbw2Y/D3MQ6y8aC+1ZReH7vfcG6LKjrFi8cYvlTy+DB1Wnd8VSLPjr5emnXaZn56G52 RH4UhFv1WLS+DDjMU7hNDtGiLFxDtVjTSGP4AQ/dMF7qoOJ/97Gt0lj/VGNkTq7DdwLHKEB1GfG ZjBSTrRubs4innqK0ZdZB9k+roLnbXCZNhnJ3ywmr+m2ur6K72DT6nfbG3p9l8dLbdQ2Og73a/m El8sFVt8fcrDxqlSorVUxjvEQtRe+hQNiezyXNWmvHTZhi2DY6RYDw+PqAaKvegua/y9oAw9Xml lv3+O6ppbT621Zo/9aPvjZWjbqYLqK07kXSYV1itsb0/cQz79Q5e/OxC8yhtU8xfbu9L5KHkfDT h3P8xF2vSwSZThyIEby2ZEldQnL3rbZraiysaU6Is1UFdNcUTXI2uz4 X-Received: by 2002:a17:902:f546:b0:2e9:84f2:3738 with SMTP id d9443c01a7336-2e9a6834a2emr83038475ad.6.1792463566680; Mon, 19 Oct 2026 19:32:46 -0700 (PDT) Received: from [192.168.1.19] (58-190-153-33f1.hyg1.eonet.ne.jp. [58.190.153.33]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ea151817a7sm7403425ad.63.2026.10.19.19.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 19:32:46 -0700 (PDT) Message-ID: <949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com> Date: Tue, 20 Oct 2026 11:32:44 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction To: shihao zhong Cc: Ayush Tiwari , alpkeles99@gmail.com, pgsql-bugs@lists.postgresql.org References: <19760-8f9a0eba17bc8c92@postgresql.org> <41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com> <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com> Content-Language: en-US From: Takeshi Ideriha In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Shihao >> So I believe we can just rely on HeapTupleHeaderXminInvalid hint bit. > > I tried it and it keeps the row in both cases. But it also needs the > logical_rewrite_heap_tuple() call in end_heap_rewrite(). Without it, > logical decoding after VACUUM FULL pg_class fails: > >   ERROR:  could not map filenumber "base/16490/16491" to relation OID > Thank you for replying. Glad to know it worked for both two cases. Regarding logical_rewrite_heap_tuple() part, you are completely right. I tested by myself yesterday and hit the same error while decoding the vacuum full scenario. Thank you for pointing out. I was not aware of DDL case with logical replication. Regards, Takeshi Ideriha