Message-ID: <94e25cc06968f0fa2813d7bac541be848b81369c.camel@cybertec.at>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in
 catalog
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: =?ISO-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>, Virender
 Singla <virender.cse@gmail.com>, pgsql-bugs@lists.postgresql.org, Aniket
 Jha	 <aniketkumarj@gmail.com>
Date: Fri, 21 Feb 2025 22:39:40 +0100
In-Reply-To: <3137106.1740155469@sss.pgh.pa.us>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql>
	 <2939991.1740089974@sss.pgh.pa.us>
	 <b0459688caa95c77f439bebf3b30341169986369.camel@cybertec.at>
	 <3073713.1740148903@sss.pgh.pa.us>
	 <58e47d097ed2a1512f47891293a7102d573fc970.camel@cybertec.at>
	 <3137106.1740155469@sss.pgh.pa.us>
User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) 
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/94e25cc06968f0fa2813d7bac541be848b81369c.camel%40cybertec.at>
Precedence: bulk

On Fri, 2025-02-21 at 11:31 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > Thanks for the explanation.  That might be worth a comment.
> 
> The adjacent comment already says
> 
> 	/*
> 	 * Advance command counter so we can see new record; else tests in
> 	 * AddRoleMems may fail.
> 	 */
> 
> so I didn't see anything to add there.  Maybe "We can skip this in
> cases where we will not call AddRoleMems"?  Or maybe the better answer
> is to conclude that the whole idea of not calling
> CommandCounterIncrement unconditionally is too fragile and not worth
> expending brain cells on, and just rip out the if-test.

Both the extra sentence and the simplification feel like an improvement.
I am fine with either.

Yours,
Laurenz Albe

-- 

*E-Mail Disclaimer*
Der Inhalt dieser E-Mail ist ausschliesslich fuer den 
bezeichneten Adressaten bestimmt. Wenn Sie nicht der vorgesehene Adressat 
dieser E-Mail oder dessen Vertreter sein sollten, so beachten Sie bitte, 
dass jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder 
Weitergabe des Inhalts dieser E-Mail unzulaessig ist. Wir bitten Sie, sich 
in diesem Fall mit dem Absender der E-Mail in Verbindung zu setzen.

*CONFIDENTIALITY NOTICE & DISCLAIMER
*This message and any attachment are 
confidential and may be privileged or otherwise protected from disclosure 
and solely for the use of the person(s) or entity to whom it is intended. 
If you have received this message in error and are not the intended 
recipient, please notify the sender immediately and delete this message and 
any attachment from your system. If you are not the intended recipient, be 
advised that any use of this message is prohibited and may be unlawful, and 
you must not copy this message or attachment or disclose the contents to 
any other person.