From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Ewan Young <kdbase.hack@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>,
        1217816127@qq.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19545: Integer truncation of `GinTuple.keylen` causes
 out-of-bounds read in parallel GIN index build
In-reply-to: <e3298f25-f77b-493f-be27-4c380454262e@eisentraut.org>
References: <19545-0f25b7e47351e8fc@postgresql.org>
 <CAON2xHMXYLwkq4UaNbUtmaw1ZKne6OqdyyiACFQUbCj+XRBvQQ@mail.gmail.com>
 <d02fd089-b326-417a-ab2c-aea88e459c63@iki.fi>
 <CAON2xHPV-7O0MsFuizJv8cbUG7ZJfLCAqzkGYgoxF9WBe1v9Jg@mail.gmail.com>
 <d6680315-bc66-48c3-a310-bdad88a86a59@iki.fi>
 <CAON2xHN5qGXcn1Z00pQAogf4y5rCQ1K04yvrYAORBa5i+ucLBQ@mail.gmail.com>
 <479d6c7e-362c-41d8-a263-8d126ecdfd77@eisentraut.org>
 <CAON2xHOv4M3rcLzhRcduSMqqmBgzWpZOR9TsK71_agAPNgi=Tg@mail.gmail.com>
 <e3298f25-f77b-493f-be27-4c380454262e@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Mon, 14 Sep 2026 18:03:15 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <954959.1789697246.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 17 Sep 2026 22:07:26 -0400
Message-ID: <954960.1789697246@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/954960.1789697246%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> I have committed these, thanks.

The ABI-compliance-checking buildfarm animals have all been unhappy
since this went in:

'struct GinTuple' changed:
  type size changed from 16 to 24 (in bytes)
  1 data member deletion:
    'uint16 keylen', at offset 6 (in bytes)
  1 data member insertion:
    'union {Size keylen; double force_align_d; int64 force_align_i64;} u',=
 at offset 8 (in bytes)
  there are data member changes:
    'int16 typlen' offset changed from 8 to 16 (in bytes) (by +8 bytes)
    'bool typbyval' offset changed from 10 to 18 (in bytes) (by +8 bytes)
    'signed char category' offset changed from 11 to 19 (in bytes) (by +8 =
bytes)
    'int nitems' offset changed from 12 to 20 (in bytes) (by +8 bytes)
    'char data[]' offset changed from 16 to 24 (in bytes) (by +8 bytes)

Is it really okay to change this struct in v18?
If so, the .abi-compliance-history files need to be updated.

			regards, tom lane