From: Tom Lane <tgl@sss.pgh.pa.us>
To: Wolfgang Walther <walther@technowledgy.de>
cc: Stephen Frost <sfrost@snowman.net>, pgsql-bugs@lists.postgresql.org
Subject: Re: User with BYPASSRLS privilege can't change password
In-reply-to: <3e771893-1ed1-97e7-6c4a-7b0d00992103@technowledgy.de>
References: <a5548a9f-89ee-3167-129d-162b5985fcf8@technowledgy.de>
 <923005.1604420579@sss.pgh.pa.us> <956994.1604425451@sss.pgh.pa.us>
 <3e771893-1ed1-97e7-6c4a-7b0d00992103@technowledgy.de>
Comments: In-reply-to Wolfgang Walther <walther@technowledgy.de>
	message dated "Tue, 03 Nov 2020 19:05:32 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <958491.1604427541.1@sss.pgh.pa.us>
Date: Tue, 03 Nov 2020 13:19:01 -0500
Message-ID: <958492.1604427541@sss.pgh.pa.us>
Precedence: bulk

Wolfgang Walther <walther@technowledgy.de> writes:
> This is because the "must be superuser to alter replication users" 
> condition only triggers when the altered role already has isrepliaction, 
> so isreplication could very well be >= 0 here.

How do you figure that?  This is in an "else" path after

	else if (authform->rolreplication || isreplication >= 0)

so AFAICS it's impossible to get there.  If it isn't impossible,
we have a much bigger hole with respect to issuper.

			regards, tom lane