Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rHZT4-0035UE-Kp for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Dec 2023 01:09:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rHZT3-00Fd6s-9h for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Dec 2023 01:09:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rHZT3-00Fd6k-1H for pgsql-bugs@lists.postgresql.org; Mon, 25 Dec 2023 01:09:17 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rHZT0-00Dk3x-3k for pgsql-bugs@lists.postgresql.org; Mon, 25 Dec 2023 01:09:16 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40d3ae326f6so39584635e9.3 for ; Sun, 24 Dec 2023 17:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20230601.gappssmtp.com; s=20230601; t=1703466553; x=1704071353; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=yIbmZVJilPH2KuJQS8nuWDVhATqE+0j1Zi7dd1Vm+pw=; b=h5dJ8uXxG02W0yF5sfIVprd400eabVrO4u/p95wjxDV2v6xrvO0XnMSCp9IBPsBCsG IO5M72GTBGiUeEOLjz6aSpuSs6Q/rXfkzI2H0hf8rvD+U90V5FG5cCuGtsUL7XVUgeev LTQqgk5ySYFElUPElEXnBPcCqEht3LAfgDDFo6QRBco+vPo0Xb1R0JbYly4aEgCNf6j3 wma3Oh/otuxvzFHVmcolyRO3ER4q+24gbagEEPWrPRDlLF6/gX2KT+kxAe4TgvZsqqP2 xkfMntE0xgeoNLdgOAv05O0so91V8WnG6th6sz94YJTQWGaPGb06SMhsnfKhb92pMTcd tJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703466553; x=1704071353; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yIbmZVJilPH2KuJQS8nuWDVhATqE+0j1Zi7dd1Vm+pw=; b=sIQ+UxYvV5uMoqcYNApOYoSWc5pzFHhsPPZSxi1rDY3kxHVeXla7Wkkv46hvp3/8Ly PrnD4TkWuzaCso1J6tk0/9AQkRJIhWo0Bc20CkTdnivdx0e0kdfijPJROsCIkIoNf8Aw 3up+cBf5ic75FFqrfXAB6WXvih5bOIQLDnVjx80LhBjpoHnRK5x7etkvuUHMWRh83md0 ogEL5DuS1mNK5uOQhCZrf845nv2KvRygYEp9XGjKwEzUeM7/CHizRP+xPieZXiLKAjCf s7/cGB2+GXY3i6a3dzJKkZkZE0JUAt82lWhka5nqM4lWjMN4osphrdm3Iy1Qxp/gctFF PgrA== X-Gm-Message-State: AOJu0YwUjrDLgLESAVyFtzqiZTxNktysHu6qmTcbu9WiCx6ks6M8b2Jg q5j0cfxoSlodqMF5oxTEI7UFYmkniyJkjg== X-Google-Smtp-Source: AGHT+IFzUvdtcDvP/Vteivf/sD6JNVwfz98IKWS9T30XYKciUczrjweWNBD3Un3gHL5RrpqxEfDy/A== X-Received: by 2002:a05:600c:3c8a:b0:40c:34ca:8f18 with SMTP id bg10-20020a05600c3c8a00b0040c34ca8f18mr2813365wmb.127.1703466552990; Sun, 24 Dec 2023 17:09:12 -0800 (PST) Received: from localhost.localdomain ([2001:871:260:3847:520b:d1da:f0f6:90a]) by smtp.gmail.com with ESMTPSA id b7-20020a5d45c7000000b00336c6b77584sm351668wrs.91.2023.12.24.17.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 17:09:12 -0800 (PST) Message-ID: <95e42d647797220ae2c2e0574caef3643e641f03.camel@cybertec.at> Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends From: Laurenz Albe To: Tom Lane , "Jonathan S. Katz" Cc: Michael Paquier , David Rowley , exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Date: Mon, 25 Dec 2023 02:09:12 +0100 In-Reply-To: <1673413.1703442075@sss.pgh.pa.us> References: <18240-c5da758d7dc1ecf0@postgresql.org> <2171714.1702307153@sss.pgh.pa.us> <2433182.1702391878@sss.pgh.pa.us> <3453263.1702739958@sss.pgh.pa.us> <1673413.1703442075@sss.pgh.pa.us> Autocrypt: addr=laurenz.albe@cybertec.at; prefer-encrypt=mutual; keydata=mQINBGGDwAQBEADgbWy5cKXQld3N2mF+DFyiNFbi2oBl2T+XgxpPF8wTRw2D/u4bBKXP0SYSE/lA86jIVNWWU0gf1KODIkVvgJm2w4vH2VBV1b7ddVViGl1Iu+9zaRnv9wulhnH42KefepXnoean6UT1EzLM0opF/Ik0j+40TxdRtobkBprkQUyHDXWlHc2ffPs3SipyFEP9AVLf7ejRC46CXWDnsqjOBSMEW8Z4HiK/8RrPZBsKLts8dJxKF4pygOdJb0CWk8k/X1jbcfdxo+zOLjOMvJcSJ2pFdJmQHU+JufB3rePziqQ2S9Ur6sccr9XnTC1GVBWN4Lf5VHq+vf+bFJjVwg+2hrySZnAVfcOrxoqFLErr7ug1zN2nM1kcpgA4VWn4gxlJtYNYYq+9WxX5dtvnNANlG3ZCrRKQzl8lxtzoF6Zo7LUhEqPaHDwn7Rvs+IdbOn41lF5UDTJGqmC4gS/bZydW2Fy3YWm4aSaN9fgFf8D+PVkrlKAZB7gBLz1TyHjbcRf85cYF+GKKrDld5SzMB/V60VX3oP/Eo8ikFpyWaqiz1f9X7MBot3/PjJkY+wDzp3nmb19QEcOBuQiSQ4xds2r0HewbuHTAR68u8jNNMGmpm2j4x+g09Jd/WQDjqlTBZ/jEltH41fYCCPWMfljXTOOXu2eLNGdfi7ETZogtwjM9oTtSPQARAQABtCdMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5hdD6JAk4EEwEIADgWIQR0CqhbZGGABqoaSbdi8bhXA2EdmAUCYYPABAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBi8bhXA2EdmM/6EADK232JCwmBzhlj8h7U9CjG6kx0JHP3uJGv+XfsHtHAlmY/RCwF1BHMEsRlk bT5UrLvJ2jb99bA9QARzhFaxzyn0F/BUKzuIjRGNs/n6d5dNUFA0kOt8sX+TacmC GEyjEBCrVCm4ranBiUyePn9NhHNWnaex7pJyqvMLLdwW9BEMJx0Fqo+DN8ukbXmYRsmhEtd3ue+x/luYmOmJnaGtzInaY5aOJYbW9XqoRIZkZvOCgbi1FfvNmoqWa+3oVxTOgw9RafjJDyW0lTHzKGjbGI5ofMU98l+/hKJFYJqWUF6VpFJY5YIcN/1lf4ZICMwDl+MPIVo/tpq8L10seJL28nLlvw3K+cI+TVW8IW/qL/LyVoDofI3USeOORuYmhpWRhik8JXX6xf3v6GrRilJIPWNFIJbxm1ZblQiQnOw3IOW7T+8nAmPin1HKqM3VrOrJQ2VtShsefNBibNAsr1oFaqcDBkn3yGG8i6CTW+FyO4PZ+/EwNxMVgktxbYdy5AT1/lpXr5tB+phhLIyVfiBvrWs5EThxYMQ/L8Y85c3GMsAy1l/x4h3jqySIYy3SCU9+jc5UVuNnXljbvkEzJ+NLWJ6C1rACFWrMszgPdh5tCrlRY9PpmYll4JbCgb8BtxEIUmR+xr50/ZElEK5iml7Q00KUekCcDt+36PsyGFTXBzNOrkCDQRhg8AEARAAzOZ2tLHlI4rrhG411h6cdCFjBZxuljaFCxFyHn3m6wbGLqwBUWC5k8UrRqjHMz88KcTSaNO7XGAmCqPdWd2SeflPZRnNTbjsVpw7mLdffsBm4JX7kki2Pvk5h0NtYeidXT1PSpc2ri4DutYXuT9uD8RAm1wUDCE5HQNUihT/WH6opt+hskHW21uHao0+y822tG0QQcGMqdQR5Vxdxj89wiEPdqW+HpU/oOZIhrf2E7prduAppxixjHy/o1rcnoznnJvc8D3+YgI9O0LrBMij89dM55pRGbLovTR1oGR3U74sX774+0xmSzeIKwZfiMUz7Atlvfk5SHOsRUFPN2Ux9kaXiiBibQpHFxt7b lDrT4wxdLJ/XCdbPPAyl+lZtOLsaHEEZvYNyTXwZc35dVf3R4/oz20HoG6s7ct8e1 AQygj43XAERzty9SkWgxs8+grp1PrGx6FHVSYRqBM8dS/ZR6yRVwOwJXPyaSSqfIF21DkE4j1y4n+ItSewPGoRp8K/yWCikt6qlkVkO2ASNIiX04fAbtzwVOaNn8ZMRNqyvLc1fED4sr49onE4cAIcBLjcC3KL+w9DUGRQCdziROj5H2Yl/sXGPdMciUHo/Uz2rggc+2th3bQiMhrHWSsBpUkDQp0yWewemstPpPgBL3h2fHKaX8B9oH5Qu/H1IgrOuX8AEQEAAYkCNgQYAQgAIBYhBHQKqFtkYYAGqhpJt2LxuFcDYR2YBQJhg8AEAhsMAAoJEGLxuFcDYR2YuPwQAMkpGtR80pQ1gVsONhdkqj0H2eU66efP/gO3CoyaoIcvrpKYj7C2HipVSmkt1gpByL0X4AMQ/vKuknUz3wd28Ba+G1dCfbVs/Xiusq+SmpUj5rTwmYqdSjWMuCo1R6oS5hdJMdUUJYGMT0QkVlm1KnW8jkmCTl9GzjDxOAsN9O6/6lPzaGFtk9XF+34Bry/N4HKiJkqpC4+UTd0AprPfzJ2jdT64e1F0+W88X8y1bTTgNrHwK4mDiLnlE4SKRuEm54lNhJz//ar86Or5BErzNpM6TL7lk44QS06hwsMrEdKIy8J/SYJPjfzR8tIUnKscclVpOgjKaBqC+0iFiVaRqAgfOlIEiezX6kMh5Q2FIUfqs46qWhhXjRrdKOEoStYAaikdLu5ZXr7vfb0ZaDh+ZwTQtbSMFolyOkecwI81MCdbMfT/1TqIGTOdAj5as9fAakk0jb2pXgUYQ8X1DVTR8ahSDVEaw9VTmWiSvTxvguVJ1Mb7gG4Gmh6aviDTJhfXtH4rPUNXhDLqrTH8JkJjyKROOMakIF68Hjse5vUfUxreBEOtb5r1Coa2Fe7ncJayaSE7ryrDbFqpZ 36UMAx4ulWMyqJajLNGY0DdG8qIsR5nxRhrnK/mrCidZ8F9/D3bWAl4rjtHlsztN59 +AnW5l0HsQcY9ntFL/zEBOaonjdJf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, 2023-12-24 at 13:21 -0500, Tom Lane wrote: > "Jonathan S. Katz" writes: > > I'm of the strong opinion that we should get rid of money. I personally= =20 > > haven't encountered it in the wild -- I'm sure it's there, but it seems= =20 > > limited -- and most apps that seriously deal with money will either use= r=20 > > either "numeric" or an integer-based type. >=20 > Yeah, maybe we should just do it. I was pleasantly surprised by how > little push-back we got from nuking the 32-bit datetime types a few > releases ago; perhaps this one would likewise not have much of a > constituency. There are questions on Stackoverflow: https://stackoverflow.com/search?q=3D%5Bpostgresql%5D+money But of course it is hard to say if these are production uses or just experiments. Yours, Laurenz Albe