From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Peter Dyballa <Peter_Dyballa@web.de>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19062: PostgreSQL 12.22 does not compile because of
 conflicting types for CollationCreate
In-reply-to: 
 <CA+hUKGJFXobNm4h6nBLuktyMvMEbwUeqicFaLdZZt6h3BH204w@mail.gmail.com>
References: <19062-878185d630b541b4@postgresql.org>
 <3315814.1758724884@sss.pgh.pa.us>
 <CA+hUKGLBMYh-CFM6imQdcrZ0ROsR6k1Lcf2Lpf_1mH4kZ=Jr3Q@mail.gmail.com>
 <1F5AE8D5-EB64-4D93-83C1-15C821B96480@Web.DE>
 <CA+hUKGJFXobNm4h6nBLuktyMvMEbwUeqicFaLdZZt6h3BH204w@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 02 Oct 2025 13:08:30 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <965385.1759369441.1@sss.pgh.pa.us>
Date: Wed, 01 Oct 2025 21:44:01 -0400
Message-ID: <965386.1759369441@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/965386.1759369441%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> FTR what I was suggesting is something like CPPFLAGS="-D_STDBOOL_H"
> (or append that to anything else you are already putting in CPPFLAGS
> on the configure invocation), which should prevent <stdbool.h> from
> having any effect, meaning it can't hide c.h's definition.  I don't
> know what concrete ABI dangers lurk in this area, but it doesn't look
> like ICU uses bool in public interfaces, preferring its own UBool, a
> typedef for int8_t.  Hmm, so it's not immediately clear why it
> includes it... but I'm too lazy to check.

Yeah, it's hard to get excited about putting effort into this.
As of PG 18 (97525bc5c) we've moved on permanently from
supporting machines where the native bool type is not of size 1.
Theoretically it should work in older branches as long as you
don't try to interact with any libraries that use bool in
their headers --- so taking out --with-libxml and perhaps
--with-icu is probably the minimum requirement for that.
But we haven't been testing such platforms since around 2022,
so who knows if it still works in recent minor releases.

Peter, perhaps an answer if you want to keep retrocomputing
on this hardware is to use NetBSD?  That does work for me
on an old G4 laptop, and it has sizeof(bool) == 1.  See
buildfarm member mamba ...

			regards, tom lane