From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: "David E. Wheeler" <david@justatheory.com>,
        Christophe Pettus <christophe.pettus@pgexperts.com>,
        pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: BUG #14825: enum type: unsafe use?
In-reply-to: <1090.1506365074@sss.pgh.pa.us>
References: <20170922185904.1448.16585@wrigleys.postgresql.org>
 <15165.1506116768@sss.pgh.pa.us>
 <3cece400-af56-7145-2e65-f044de1b0b68@2ndQuadrant.com>
 <28968.1506136792@sss.pgh.pa.us>
 <f29e2d7e-7d71-b3b7-2fed-d52bddd8ca61@2ndQuadrant.com>
 <24380.1506179805@sss.pgh.pa.us> <16272.1506189656@sss.pgh.pa.us>
 <928f5974-151f-0273-0221-fac213e7624f@2ndQuadrant.com>
 <19137.1506196325@sss.pgh.pa.us>
 <4942e2c0-3302-f496-d4c1-a967f77d0143@2ndQuadrant.com>
 <25662.1506204381@sss.pgh.pa.us>
 <9479302a-09b8-4264-f9c4-514b65f18547@2ndQuadrant.com>
 <18127.1506285450@sss.pgh.pa.us>
 <2770f70a-5977-3fa1-1065-11b4cc69f07f@2ndQuadrant.com>
 <23438.1506294409@sss.pgh.pa.us>
 <a9a175c3-164b-6997-8b97-c04d1c2df753@2ndQuadrant.com>
 <25809.1506348877@sss.pgh.pa.us>
 <b2890b9d-2383-955f-786c-8e252dce04cb@2ndQuadrant.com>
 <27064.1506350579@sss.pgh.pa.us>
 <5f4f29bf-90b1-e49a-6cf9-069c59bc1067@2ndQuadrant.com>
 <40FDB1F3-932D-4912-B4C7-F1E26E331079@justatheory.com>
 <7ca5214d-f981-54e4-c65a-470a87aa665e@2ndQuad!
 ! rant.com> <1090.1506365074@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 25 Sep 2017 14:44:34 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9665.1506446327.1@sss.pgh.pa.us>
Date: Tue, 26 Sep 2017 13:18:47 -0400
Message-ID: <9666.1506446327@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

I wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> OK, that seems to be the consensus. So let's apply the blacklist patch
>> and then separately remove the 'created in the same transaction' test.
>> We'll need to adjust the regression tests and docs accordingly.

> Agreed.  I'll work on that in a little bit.

Pushed; sorry for the delay.

I noticed that the blacklist mechanism effectively removed the prohibition
against using a renamed enum value later in the same transaction, so I
added a regression test for that.  Also, as committed, I used RENAME TYPE
rather than ALTER OWNER in the test cases requiring an updated pg_type
row.  That way we don't need to create a role, even a transient one, which
is a good thing in terms of not risking collisions with other sessions.

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs