Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iGnE9-0002qE-Ut for pgsql-bugs@arkaria.postgresql.org; Sat, 05 Oct 2019 16:48:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iGnE8-0000vO-BS for pgsql-bugs@arkaria.postgresql.org; Sat, 05 Oct 2019 16:48:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iGnE8-0000v9-0v for pgsql-bugs@lists.postgresql.org; Sat, 05 Oct 2019 16:48:16 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iGnE1-000886-En for pgsql-bugs@lists.postgresql.org; Sat, 05 Oct 2019 16:48:14 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x95Gm4qt009701; Sat, 5 Oct 2019 12:48:04 -0400 From: Tom Lane To: Andres Freund cc: stuchalin.d@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16042: incorrect .gitignore file In-reply-to: <20191005163402.cotdvskqglhar3wn@alap3.anarazel.de> References: <16042-c174ee692ac21cbd@postgresql.org> <8877.1570292881@sss.pgh.pa.us> <20191005163402.cotdvskqglhar3wn@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sat, 05 Oct 2019 09:34:02 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9699.1570294084.1@sss.pgh.pa.us> Date: Sat, 05 Oct 2019 12:48:04 -0400 Message-ID: <9700.1570294084@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2019-10-05 12:28:01 -0400, Tom Lane wrote: >> Yeah, somebody was being overly lazy there. I cleaned it up. > Seems like adding a !rmgrdesc.c pattern would have a been easier? I'm not terribly trusting of this sort of wildcard usage in .gitignore to begin with. It's way too easy to ignore something you shouldn't, as indeed this bug did. regards, tom lane