Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1nSlKH-0001hg-LD
	for pgsql-bugs@arkaria.postgresql.org; Fri, 11 Mar 2022 19:53:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1nSlKG-0007Mc-BS
	for pgsql-bugs@arkaria.postgresql.org; Fri, 11 Mar 2022 19:53:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nSlKG-0007MR-2S
	for pgsql-bugs@lists.postgresql.org; Fri, 11 Mar 2022 19:53:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nSlK9-0006f3-Un
	for pgsql-bugs@lists.postgresql.org; Fri, 11 Mar 2022 19:53:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22BJrCJ5982895;
	Fri, 11 Mar 2022 14:53:12 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
cc: Dmitry Koval <d.koval@postgrespro.ru>,
 Dilip Kumar <dilipbalaut@gmail.com>,
        andrewbille@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable
 transaction causes Assert at the transaction end
In-reply-to: 
 <CAD21AoA2sivebwQw9602CBf8URFWGKY0=qE6=2wDkm2YhRKnOw@mail.gmail.com>
References: <17385-9ee529fb091f0ce5@postgresql.org>
 <b22395d2-d432-f211-0bed-1f466df75152@postgrespro.ru>
 <CAD21AoCkwsb_Hz6JYbG0X8Jf_VEMheiib0FXpR2kc3UATVCPNQ@mail.gmail.com>
 <CAFiTN-sYZ0Cuyeygp7z8xfoFPhqTAbtnV+k2W9OHp8s0xus5vw@mail.gmail.com>
 <f97d670d-2b03-9d47-6b64-09e6ed2f4d84@postgrespro.ru>
 <CAFiTN-sCr6mYg8A_BBiRz0N68M9QY3uoBWHhbPgHDM-goLJGwg@mail.gmail.com>
 <6e31c4ef-de9a-960b-1a21-e3b6ff0fa9c2@postgrespro.ru>
 <CAD21AoB8acvjt+52iwffAi7Ary_fyMD70X371hVX1JULrc-meQ@mail.gmail.com>
 <2733419.1644789029@sss.pgh.pa.us>
 <CAD21AoCxz=hU3c+6aB3OMNn+9NpH33WEMwOYmCOwh6EzOktYoA@mail.gmail.com>
 <2778050.1644817168@sss.pgh.pa.us>
 <CAD21AoAVuQ=TCCqA1D=eVqG3G_bKLq2zpNeYVV34Ucu2208Hmg@mail.gmail.com>
 <3054063.1644944122@sss.pgh.pa.us>
 <CAD21AoD5MsR_GR5iipc8TnGa3grzQbPLpwZcSn8Fq2dZbar_6g@mail.gmail.com>
 <515672.1646838707@sss.pgh.pa.us>
 <CAD21AoAEHLAJ3=_zoCicyaPSf9-2PnJBb8HixLwPN-rLA6wzNQ@mail.gmail.com>
 <CAD21AoA2sivebwQw9602CBf8URFWGKY0=qE6=2wDkm2YhRKnOw@mail.gmail.com>
Comments: In-reply-to Masahiko Sawada <sawada.mshk@gmail.com>
	message dated "Sat, 12 Mar 2022 00:39:53 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <982893.1647028392.1@sss.pgh.pa.us>
Date: Fri, 11 Mar 2022 14:53:12 -0500
Message-ID: <982894.1647028392@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/982894.1647028392%40sss.pgh.pa.us>
Precedence: bulk

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> I've attached a draft patch for discussion.

Hm, I think that trying to RESET a GUC_NO_RESET variable ought to
actively throw an error.  Silently doing nothing will look like
a bug.

(This does imply that it's not sensible to mark a variable
GUC_NO_RESET without also saying GUC_NO_RESET_ALL.  That
seems fine to me, because I'm not sure what the combination
GUC_NO_RESET & !GUC_NO_RESET_ALL ought to mean.)

			regards, tom lane