Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: BUG #19457: RE:  pgp_sym_encrypt silently accepts non-FIPS
 ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <aervokmPnxlO6Oqs@paquier.xyz>
Date: Fri, 24 Apr 2026 10:11:04 +0200
Cc: ansh01072001@gmail.com,
 pgsql-bugs@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <99F0B98C-2276-4C01-B553-BDD0806CAEEF@yesql.se>
References: <19457-4bab15c17aea36c7@postgresql.org>
 <3A2299BC-1684-4CEB-BD65-1DEBFB446F24@yesql.se>
 <aervokmPnxlO6Oqs@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/99F0B98C-2276-4C01-B553-BDD0806CAEEF%40yesql.se>
Precedence: bulk

> On 24 Apr 2026, at 06:20, Michael Paquier <michael@paquier.xyz> wrote:
>=20
> On Tue, Apr 21, 2026 at 04:04:40PM +0200, Daniel Gustafsson wrote:
>> Not just FIPS, it should check CheckBuiltinCryptoMode() to be =
consistent with
>> the other builtin checks.
>=20
> I am interesting in getting that fixed for the next point release, so
> I have given it a try, finishing with the attached.  This would cause
> pgp_sym_encrypt() and pgp_sym_decrypt() to complain when the builtin
> mode is disabled, making things more consistent with the surroundings.
>=20
> I agree that this could break environments where builtin_crypto is
> off, as the functions would now be blocked, but I am not sure that
> this is worth worrying about as builtin_crypto=3Don is the default.

I'm not convinced this is material for a minor release, the feature =
works as
documented and it was never documented to cover PGP.  Re-reading the =
thread PGP
was never discussed, and while that admittedly seem like an oversight =
doing
this in a minor release will alter documented behaviour which is =
generally not
what we want to do.

--
Daniel Gustafsson