Message-ID: <9b3a9dce-c909-4da4-a3d8-daae0135714d@dunslane.net>
Date: Thu, 29 Aug 2024 11:16:53 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [EXTERNAL] Re: Windows Application Issues | PostgreSQL | REF #
 48475607
To: Thomas Munro <thomas.munro@gmail.com>,
 "Haifang Wang (Centific Technologies Inc)" <v-haiwang@microsoft.com>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>,
 Rahul Pandey <pandeyrah@microsoft.com>,
 Vishwa Deepak <Vishwa.Deepak@microsoft.com>,
 Shawn Steele <Shawn.Steele@microsoft.com>,
 Amy Wishnousky <amyw@microsoft.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>,
 Shweta Gulati <gulatishweta@microsoft.com>,
 Ashish Nawal <nawalashish@microsoft.com>
References: 
 <PH8PR21MB390263C479B81A1B7330E744E5182@PH8PR21MB3902.namprd21.prod.outlook.com>
 <PH8PR21MB39022FCDB4806CD57694F50AE5FF2@PH8PR21MB3902.namprd21.prod.outlook.com>
 <CA+hUKGK-G=DB5MttZzzZf7mzTMxRVSACNg-WGK59Tk1Q9vY3cA@mail.gmail.com>
 <CA+hUKGJO7Ma=30ayjwAhFPQ41Hej_mSsCUb3Kr22i-cr3qxM0w@mail.gmail.com>
 <CA+hUKGJTOgnTzu4VD6Am0X6g67atkQHFVk+C-w5wkGrGiao-=Q@mail.gmail.com>
 <0ba29a3c-9c1c-44c4-84a0-3405f8464075@dunslane.net>
 <CA+hUKGJasTBQ1THqDeeVdeRSFao3+T1LGnwJfqmT4sR-WmTebQ@mail.gmail.com>
 <dd630b4a-e136-42d4-814e-954f9c03f90a@dunslane.net>
 <CANFyU963Cf1RK0AZ99muoKWCZKGB0+RTMVeZ5J57upksR1qgnQ@mail.gmail.com>
 <CA+hUKGKa7R23AqDFnLymLuLU0E7fjCnd0=SBe50VXonYLG0EiA@mail.gmail.com>
 <CANFyU94EO+_9Qj5CDK=Ei6pxXyZu9FMOw8rJ1zr-VqkY3fq+0g@mail.gmail.com>
 <CA+hUKGJtx=o0Td4JjJ9-P+HMuKZpf6cnmu=_dx9hr2THC08wsQ@mail.gmail.com>
 <PH8PR21MB3902C154DA07EC6206E9372BE58B2@PH8PR21MB3902.namprd21.prod.outlook.com>
 <CA+hUKG+yLnVjc7qw1ac32GCzRUenXrK=3=nCvwP-LJBL8wVTEg@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: 
 <CA+hUKG+yLnVjc7qw1ac32GCzRUenXrK=3=nCvwP-LJBL8wVTEg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/9b3a9dce-c909-4da4-a3d8-daae0135714d%40dunslane.net>
Precedence: bulk


On 2024-08-28 We 6:16 AM, Thomas Munro wrote:
> On Tue, Aug 27, 2024 at 9:29 AM Haifang Wang (Centific Technologies
> Inc) <v-haiwang@microsoft.com> wrote:
>> Just would like to follow up with you about this bug. How is it going with the investigation?
> Well, we figured out that Windows is aborting inside setlocale().  The
> C standard says "The pointer to string returned by the setlocale
> function is such that a subsequent call with that string value and its
> associated category will restore that part of the program’s locale."
> Window does not conform, and crashes itself.
>
> One practical change we could make would be to reject non-ASCII locale
> names in initdb, as in the attached, and back-patch to 16.  Then the
> EDB installer (a separate project that is calling initdb and providing
> the non-ASCII string containing "ü") would at least get a graceful
> failure instead of a crash.  It hardly makes a difference to the user,
> but I've finally understood that these crashes in the Windows runtime
> library might be generating a stream of crash reports to Microsoft,
> which might be bringing you here?
>
> For example:
>
> $ initdb -D asdf --locale="liberté"
> The files belonging to this database system will be owned by user "tmunro".
> This user must also own the server process.
>
> initdb: error: locale name "liberté" contains non-ASCII characters


+1 for doing this.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com