Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xN7Jj-00000002Ndk-1H3l for pgsql-bugs@arkaria.postgresql.org; Sat, 31 Oct 2026 11:32:11 +0000 Received: from localhost ([127.0.0.1]:57260 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xN7Ji-0000000EUM2-3gKM for pgsql-bugs@arkaria.postgresql.org; Sat, 31 Oct 2026 11:32:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:60386) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xN7Ji-0000000EULu-29mc for pgsql-bugs@lists.postgresql.org; Sat, 31 Oct 2026 11:32:10 +0000 Received: from mail-wr2-x08.google.com ([2a00:1450:4864:30::8]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xN7Jg-00000001qf8-39FI for pgsql-bugs@lists.postgresql.org; Sat, 31 Oct 2026 11:32:09 +0000 Received: by mail-wr2-x08.google.com with SMTP id ffacd0b85a97d-48e293ecaa7so454771f8f.1 for ; Sat, 31 Oct 2026 04:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793446327; x=1794051127; darn=lists.postgresql.org; h=in-reply-to:from:references:cc:to:subject:user-agent:mime-version :date:message-id:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FODUrYZ+ulxRkFOPGb3Dt8L1Jm7VGbJV4zUKx8R2AfM=; b=DiGORirXe4VdLnyP0bf0bUEe2zKTOA03Pc59NRANT3pwPXQYw475LxEvXwlcJMk69N ag7bdif1XVC5P7+0mBKutUmN4E9h/+H1p+gK2Mc1JxjSfCpkd2uQXSEfB+RAXVQ7wEpF ZPVyhqY1sUS25Yzocs15uNZTS3QwXWz/U8mK58AaLv8xTOeHovYuZT5WCBZvHwaCH1GG z8ibuNlxIpA/c5eLsc+Sh7jeVLYOYC6iAcNhtx89pDrl8BTX9By2vM5VfemWrc0LmT5/ DA1JFY6U61/TRmeYumxXvO2nenwBz0ROtc+psoXPAKSVhvhizwMAktkULh2ahexkVLw9 4QAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793446327; x=1794051127; h=in-reply-to:from:references:cc:to:subject:user-agent:mime-version :date:message-id:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=FODUrYZ+ulxRkFOPGb3Dt8L1Jm7VGbJV4zUKx8R2AfM=; b=AQ8kpkE84LhrEGpg68oTg0Iot7iarW1+eGkaDXRsM8uut2yt1/9o8/CRdO7ge9/Enn EDiLcgIAU48BOEyrNBjOAO/FoNxzzVs+7wD/IizcCz0CUoOy8h53Ga95xCdq8E4iQBdm CH/u/Bbb2UQXwReKiL0gSx9ROgpHKECgEqdcQ5+vfyQI5wNGeMw9W0ERdM+EIaB/wX30 25ENwBnRCZUPMS5Y3nysKWgBmm+rBCCSaiPbkdBvbgPYl9FHEniHXL9qN8yNYkIVfAlE Pydr6VsxffvTZUZM1tVU0w/qbv69dWlmYFioblejxPIPLDCh88Gy7Udct+xthhlDooVo MVDw== X-Forwarded-Encrypted: i=1; AKwUvByVl456Rgqgls40vSDfe6Hbxqy2MDUiboZGKQ2gWCyChoAGE/7KFskeuN65s1baDAUT8bFysapPClB7@lists.postgresql.org X-Gm-Message-State: AFq9FYLyjZIMrZAVZwxDCbkYfp71LiM5qPPgJu6AFKMyRf75QqyMHb9h OL2yH9vwZr4x/RvanzjN+wKI2DHei6w8+TP/NHBpUqYLV1iZD/rJwh5r X-Gm-Gg: AYBFou0cqcJRtSn+zr46U3qsKg5iIZJMcjAjgjm2PMk3K9skELS6hk6Vsdfzb4pmL4U 20iJ79T+lDcorQG9M3EyhK17Rl4jGwB8bweoRiq3zltcE4cNPw//ppiuspO14YnyLCtYjjh9GTw 4L6rMlZQuwNa0bc9hu1MbdKmj5RbascHz1Pf4XgN3gJ9JVbRYXRgixvfOqkhT1Ffg8HLrWsRsjw 01pzaQILhrUowq+aNoWhgCYN5q67FZX7wWHE8x3NCjBzupef8x168PGDDKVlTD0FOPfvUx7S1AR NaJePUkm5xTcjJG3gsVwgmAbOjkPZRQBAr/eqRMdsFKEJA8WrKP6Gs2UShS2mojHk3wcUebdIZ9 ZBiXGkYflwsmsCi9jQJF1iUBDG8jfZ0Mv23+T2gFe05vbMOCPEHnLRDYH9pM5/YJlbnH80EyoG6 i71+0a5Xf+yU9K5NcjpVW0ldM5ChBXdkGg/2lskrCxg+1ixd0dXXbZi19HAzGS90YKlH/7LfS1g p77rAa4xKmrMkdRD458b3QY2y8hCdvHJJXVqfGxzf6bc7aygpCpqhEVxzS5ycWTlcnsoGm5mfz8 pC4WR2z66oJY/TicV1p/q+QLottI7EcI9P6FHYoX/PSf8hXgN/T3tie3eFjM//OJhwUp9CJX/hW 71CpK3NGJZO7jgGO00N58EDL9AMVboexASTU/NKulGd88+lp++4BK+GU3y9k= X-Received: by 2002:a05:6000:2c03:b0:48b:d9:cb52 with SMTP id ffacd0b85a97d-48e6e4fdddamr10240412f8f.27.1793446327250; Sat, 31 Oct 2026 04:32:07 -0700 (PDT) Received: from [17.235.221.176] ([17.235.221.176]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71baa1b3sm7968687f8f.56.2026.10.31.04.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Oct 2026 04:32:06 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------h00YwDSGExcyV9gEFy3ntzaM" Message-ID: <9bcab85a-edda-4302-bdd0-1c1cf5b7a66c@gmail.com> Date: Sat, 31 Oct 2026 19:32:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value To: "Hayato Kuroda (Fujitsu)" Cc: "brar@gmx.de" , "pgsql-bugs@lists.postgresql.org" References: <19795-6d7d506133b7f062@postgresql.org> From: Zhijie Hou In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------h00YwDSGExcyV9gEFy3ntzaM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On Mon, Oct 26, 2026 at 10:56 AM "Hayato Kuroda (Fujitsu)" wrote: > >> Attached is a patch that uses defGetString() for "proto_version" and >> "publication_names" and adds a simple test in 030_pg_recvlogical.pl >> to confirm it works. > > Thanks for the patch. One question: > > ``` > if (parsed > PG_UINT32_MAX) > ereport(ERROR, > (errcode(ERRCODE_INVALID_PARAMETER_VALUE), > errmsg("proto_version \"%s\" out of range", > strVal(defel->arg)))); > ``` > > Here strVal() is still used, but I feel it's better to refer `val` here. We can completely remove > the function call. Thanks for reviewing. Here is the V2 patch. -- Best Regards, Zhijie Hou --------------h00YwDSGExcyV9gEFy3ntzaM Content-Type: text/plain; charset=UTF-8; name="v2-0001-Fix-pgoutput-crash-on-missing-option-values.patch" Content-Disposition: attachment; filename*0="v2-0001-Fix-pgoutput-crash-on-missing-option-values.patch" Content-Transfer-Encoding: base64 RnJvbSA1NDA2OGZhMzA4NGY3Mjc5Y2UyOGIxZTljODQzZjcxNmE2NWE3YmI2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBaaGlqaWUgSG91IDxob3V6aGlqaWUyMkBnbWFpbC5j b20+CkRhdGU6IEZyaSwgMzAgT2N0IDIwMjYgMTI6Mjk6NTEgKzA4MDAKU3ViamVjdDogW1BB VENIIHYyXSBGaXggcGdvdXRwdXQgY3Jhc2ggb24gbWlzc2luZyBvcHRpb24gdmFsdWVzLgoK VGhlIHJlcGxpY2F0aW9uIHByb3RvY29sIGFsbG93cyBvcHRpb25zIHdpdGhvdXQgdmFsdWVz LCBidXQgcGdvdXRwdXQKZGVyZWZlcmVuY2VkIGEgTlVMTCBEZWZFbGVtIGFyZ3VtZW50IGZv ciBwcm90b192ZXJzaW9uIGFuZApwdWJsaWNhdGlvbl9uYW1lcy4gQSByZXBsaWNhdGlvbiBj bGllbnQgY291bGQgdGhlcmVmb3JlIGNyYXNoIHRoZQp3YWxzZW5kZXIgYW5kIGZvcmNlIHRo ZSBwb3N0bWFzdGVyIHRvIHJlc3RhcnQgYWxsIHNlc3Npb25zLgoKRml4IHRoaXMgYnkgcmVh ZGluZyBib3RoIG9wdGlvbnMgd2l0aCBkZWZHZXRTdHJpbmcoKSwgd2hpY2ggcmVwb3J0cyBh Cm1pc3NpbmcgcGFyYW1ldGVyIGNsZWFubHkuCgpSZXBvcnRlZC1ieTogQnJhciBQaWVuaW5n IDxicmFyQGdteC5kZT4KQXV0aG9yOiBaaGlqaWUgSG91IDxob3V6aGlqaWUyMkBnbWFpbC5j b20+ClJldmlld2VkLWJ5OiBIYXlhdG8gS3Vyb2RhIDxrdXJvZGEuaGF5YXRvQGZ1aml0c3Uu Y29tPgpSZXZpZXdlZC1ieTogS2lyaWxsIFJlc2hrZSA8cmVzaGtla2lyaWxsQGdtYWlsLmNv bT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS8xOTc5NS02ZDdkNTA2MTMzYjdm MDYyQHBvc3RncmVzcWwub3JnCkJhY2twYXRjaC10aHJvdWdoOiAxNAotLS0KIHNyYy9iYWNr ZW5kL3JlcGxpY2F0aW9uL3Bnb3V0cHV0L3Bnb3V0cHV0LmMgICB8ICA3ICsrLS0KIHNyYy9i aW4vcGdfYmFzZWJhY2t1cC90LzAzMF9wZ19yZWN2bG9naWNhbC5wbCB8IDM1ICsrKysrKysr KysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9wZ291dHB1 dC9wZ291dHB1dC5jIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vcGdvdXRwdXQvcGdvdXRw dXQuYwppbmRleCBiNDgxZDViYjM4OC4uYzhjYWExNjNjMTUgMTAwNjQ0Ci0tLSBhL3NyYy9i YWNrZW5kL3JlcGxpY2F0aW9uL3Bnb3V0cHV0L3Bnb3V0cHV0LmMKKysrIGIvc3JjL2JhY2tl bmQvcmVwbGljYXRpb24vcGdvdXRwdXQvcGdvdXRwdXQuYwpAQCAtMzE2LDcgKzMxNiw3IEBA IHBhcnNlX291dHB1dF9wYXJhbWV0ZXJzKExpc3QgKm9wdGlvbnMsIFBHT3V0cHV0RGF0YSAq ZGF0YSkKIAkJewogCQkJdW5zaWduZWQgbG9uZyBwYXJzZWQ7CiAJCQljaGFyCSAgICplbmRw dHI7Ci0JCQljb25zdCBjaGFyICp2YWwgPSBzdHJWYWwoZGVmZWwtPmFyZyk7CisJCQljb25z dCBjaGFyICp2YWwgPSBkZWZHZXRTdHJpbmcoZGVmZWwpOwogCiAJCQlpZiAocHJvdG9jb2xf dmVyc2lvbl9naXZlbikKIAkJCQllcmVwb3J0KEVSUk9SLApAQCAtMzM0LDggKzMzNCw3IEBA IHBhcnNlX291dHB1dF9wYXJhbWV0ZXJzKExpc3QgKm9wdGlvbnMsIFBHT3V0cHV0RGF0YSAq ZGF0YSkKIAkJCWlmIChwYXJzZWQgPiBQR19VSU5UMzJfTUFYKQogCQkJCWVyZXBvcnQoRVJS T1IsCiAJCQkJCQkoZXJyY29kZShFUlJDT0RFX0lOVkFMSURfUEFSQU1FVEVSX1ZBTFVFKSwK LQkJCQkJCSBlcnJtc2coInByb3RvX3ZlcnNpb24gXCIlc1wiIG91dCBvZiByYW5nZSIsCi0J CQkJCQkJCXN0clZhbChkZWZlbC0+YXJnKSkpKTsKKwkJCQkJCSBlcnJtc2coInByb3RvX3Zl cnNpb24gXCIlc1wiIG91dCBvZiByYW5nZSIsIHZhbCkpKTsKIAogCQkJZGF0YS0+cHJvdG9j b2xfdmVyc2lvbiA9ICh1aW50MzIpIHBhcnNlZDsKIAkJfQpAQCAtMzUxLDcgKzM1MCw3IEBA IHBhcnNlX291dHB1dF9wYXJhbWV0ZXJzKExpc3QgKm9wdGlvbnMsIFBHT3V0cHV0RGF0YSAq ZGF0YSkKIAkJCSAqIFBhc3MgYSBjb3B5IG9mIHRoZSBEZWZFbGVtLT5hcmcgc2luY2UgU3Bs aXRJZGVudGlmaWVyU3RyaW5nCiAJCQkgKiBtb2RpZmllcyBpdHMgaW5wdXQuCiAJCQkgKi8K LQkJCWlmICghU3BsaXRJZGVudGlmaWVyU3RyaW5nKHBzdHJkdXAoc3RyVmFsKGRlZmVsLT5h cmcpKSwgJywnLAorCQkJaWYgKCFTcGxpdElkZW50aWZpZXJTdHJpbmcocHN0cmR1cChkZWZH ZXRTdHJpbmcoZGVmZWwpKSwgJywnLAogCQkJCQkJCQkJICAgJmRhdGEtPnB1YmxpY2F0aW9u X25hbWVzKSkKIAkJCQllcmVwb3J0KEVSUk9SLAogCQkJCQkJKGVycmNvZGUoRVJSQ09ERV9J TlZBTElEX05BTUUpLApkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3QvMDMw X3BnX3JlY3Zsb2dpY2FsLnBsIGIvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3QvMDMwX3BnX3Jl Y3Zsb2dpY2FsLnBsCmluZGV4IDA3YWQwN2ZlZjJhLi4zMDlhNmMwNDA0NCAxMDA2NDQKLS0t IGEvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3QvMDMwX3BnX3JlY3Zsb2dpY2FsLnBsCisrKyBi L3NyYy9iaW4vcGdfYmFzZWJhY2t1cC90LzAzMF9wZ19yZWN2bG9naWNhbC5wbApAQCAtMTAw LDYgKzEwMCw0MSBAQCAkbm9kZS0+Y29tbWFuZF9vaygKIAldLAogCSdzbG90IGRyb3BwZWQn KTsKIAorIyBDaGVjayB0aGF0IHBnb3V0cHV0IHJlamVjdHMgb3B0aW9ucyB0aGF0IHJlcXVp cmUgYSBwYXJhbWV0ZXIgd2hlbiBwYXNzZWQKKyMgd2l0aG91dCBhIHZhbHVlLgorJG5vZGUt PnNhZmVfcHNxbCgncG9zdGdyZXMnLAorCSJTRUxFQ1QgcGdfY3JlYXRlX2xvZ2ljYWxfcmVw bGljYXRpb25fc2xvdCgncGdvdXRwdXRfc2xvdCcsICdwZ291dHB1dCcpIik7CisKKyRub2Rl LT5jb21tYW5kX2ZhaWxzX2xpa2UoCisJWworCQkncGdfcmVjdmxvZ2ljYWwnLAorCQknLS1z bG90JyA9PiAncGdvdXRwdXRfc2xvdCcsCisJCSctLWRibmFtZScgPT4gJG5vZGUtPmNvbm5z dHIoJ3Bvc3RncmVzJyksCisJCSctLXN0YXJ0JywKKwkJJy0tb3B0aW9uJyA9PiAncHJvdG9f dmVyc2lvbicsCisJCSctLW5vLWxvb3AnLAorCQknLS1maWxlJyA9PiAnLScsCisJXSwKKwlx ci9wcm90b192ZXJzaW9uIHJlcXVpcmVzIGEgcGFyYW1ldGVyLywKKwkncGdvdXRwdXQgcHJv dG9fdmVyc2lvbiBvcHRpb24gd2l0aG91dCBhIHZhbHVlJyk7CisKKyRub2RlLT5jb21tYW5k X2ZhaWxzX2xpa2UoCisJWworCQkncGdfcmVjdmxvZ2ljYWwnLAorCQknLS1zbG90JyA9PiAn cGdvdXRwdXRfc2xvdCcsCisJCSctLWRibmFtZScgPT4gJG5vZGUtPmNvbm5zdHIoJ3Bvc3Rn cmVzJyksCisJCSctLXN0YXJ0JywKKwkJJy0tb3B0aW9uJyA9PiAncHJvdG9fdmVyc2lvbj0x JywKKwkJJy0tb3B0aW9uJyA9PiAncHVibGljYXRpb25fbmFtZXMnLAorCQknLS1uby1sb29w JywKKwkJJy0tZmlsZScgPT4gJy0nLAorCV0sCisJcXIvcHVibGljYXRpb25fbmFtZXMgcmVx dWlyZXMgYSBwYXJhbWV0ZXIvLAorCSdwZ291dHB1dCBwdWJsaWNhdGlvbl9uYW1lcyBvcHRp b24gd2l0aG91dCBhIHZhbHVlJyk7CisKKyRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywK KwkiU0VMRUNUIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgncGdvdXRwdXRfc2xvdCcpIik7 CisKICN0ZXN0IHdpdGggdHdvLXBoYXNlIG9wdGlvbiBlbmFibGVkCiAkbm9kZS0+Y29tbWFu ZF9vaygKIAlbCi0tIAoyLjU0LjAgKEFwcGxlIEdpdC0xNTcpCgo= --------------h00YwDSGExcyV9gEFy3ntzaM--