Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIkCL-0007RQ-HG for pgsql-bugs@arkaria.postgresql.org; Tue, 23 Apr 2019 01:26:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hIkCK-0004ud-5V for pgsql-bugs@arkaria.postgresql.org; Tue, 23 Apr 2019 01:26:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIkCJ-0004uW-Ph for pgsql-bugs@lists.postgresql.org; Tue, 23 Apr 2019 01:26:11 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIkCG-0006xC-Vg for pgsql-bugs@lists.postgresql.org; Tue, 23 Apr 2019 01:26:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=G+X1sxL3p8f0RNkyXo7dBxiA1dWZ0T3DHmHGqDQkdv8=; b=6tnnbqdIr9hUaoiwGLj9srk3kl C+6MYy4lXoSePY7X/Y6Mo3aN7kJenMVBe85YEL9aOYdHMkWtl9WbDqIuQRiajO9a2ajuQ9XVAUTtv odOZak3UWFJjuCuveuncF9RPOIKHkSpIP4L4x87eOaWajsb5gA16MFlYwgMu2A9KiKgB7+FJoqHqU uWx2UzPgELkWlpPvB+d9puUOZZOVJy/wN/pHogHtlJ9BHhxJiYZ25b75gCvxv1goujwRKc3cqWqls IHIDsXGwqiebKbO/TsGN7PH2X/vs3mHz9j7Z83AD/yY9h4Q2j4Netq8DOBL54IiEZf2mwOMqg3cVS JwSF7/RA==; Received: from pool-96-250-83-19.nycmny.fios.verizon.net ([96.250.83.19] helo=Ph33r-Retina.home) by meldrar.postgresql.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIkCD-0006JD-7L; Tue, 23 Apr 2019 01:26:07 +0000 Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords To: Michael Paquier Cc: Tom Lane , pgsql-bugs@lists.postgresql.org, Stephen Frost References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> <5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org> <30284.1555972921@sss.pgh.pa.us> <15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org> <20190423010142.GE2712@paquier.xyz> From: "Jonathan S. Katz" Openpgp: preference=signencrypt Autocrypt: addr=jkatz@postgresql.org; keydata= mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC Message-ID: <9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org> Date: Mon, 22 Apr 2019 21:26:01 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423010142.GE2712@paquier.xyz> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9dLcBQyJGDhUMODgkkOrXWgsAUmRB0BUT" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9dLcBQyJGDhUMODgkkOrXWgsAUmRB0BUT Content-Type: multipart/mixed; boundary="L9HCixZmeV38QxenS7poERZrAGFCwRFOv"; protected-headers="v1" From: "Jonathan S. Katz" To: Michael Paquier Cc: Tom Lane , pgsql-bugs@lists.postgresql.org, Stephen Frost Message-ID: <9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org> Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> <5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org> <30284.1555972921@sss.pgh.pa.us> <15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org> <20190423010142.GE2712@paquier.xyz> In-Reply-To: <20190423010142.GE2712@paquier.xyz> --L9HCixZmeV38QxenS7poERZrAGFCwRFOv Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/22/19 9:01 PM, Michael Paquier wrote: >=20 > Also, the extra SELECT query with regexp_replace() is a bit overkill > for the purpose, and copying again a copy of the regexp around is no > fun. >=20 > In short, I would simplify things as the attached. What do you think? Outside of the strlen comments, I do like the changes to the tests, +1 I did purposely keep the SCRAM + MD5 changes as separate patches as I felt they were both atomic, but I have no strong opinions on that. Thanks, Jonathan --L9HCixZmeV38QxenS7poERZrAGFCwRFOv-- --9dLcBQyJGDhUMODgkkOrXWgsAUmRB0BUT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAly+aaoACgkQ8QSccp8c ZScovg/9H8tKTQZg2GzJPAG5CMjzuSJ4rH5AMooaQH4+NAu+oXHjwxmO7Nt/xLu0 bhrt93JnF62/kp3RvtFkWQgtkswprZD4HSrsciwnVTvp0LPZamR5Z7PmXHsNwPCx BbdtdUUMrIATz1pZdYGc6E6iClU1RLNQZC5f5MO9qtpmL4GjQENHcAEythu8OYNF hHEstJctvUJWaZGIreGRTlAE6LRgzOBDD26Gn3RdnlJx/CiXqtT28CBR0JQqPQGJ HZ5wdT3+jMdyyA36EtCdh616SWYLmf7Ox4ytQHWK7bZHSdV7BAwnehbCfVNDrMQ6 Eo3BB7mLc6H19MqECgwMjfo2i0h2AjoZ+niXemRXWeg5ZpKVKmV0Gieu7TOzK0zx wkNanUrqq9aVj/a9Ykq395Id9LDr/ehYcaQN+wGkcGETd/sxBjMW705XcNwh0za3 Saa3cL1DiBWpnkyPH0d/pQzS4RYOWHICX2xX/Q41TkJxuBbsLUztRcAYXPsvenq4 GNLnT1yRCsBtlMc2EDb/cTnERyADEeSKgAxysW/NblkdiEK4nS8wW0VpeCUZ7PRG vyxSNgQIRuYZZFFitQKVvpFuHv84IyjP+z3WER8jSFqpANlFx95f/WgJMWfygV5r 5AovdEYkMQTcMcHf/ICptA0K4YPKNwNJfszGzvpDHqzyQyB4VdY= =DPY2 -----END PGP SIGNATURE----- --9dLcBQyJGDhUMODgkkOrXWgsAUmRB0BUT--