Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXG8H-0005wL-3C for pgsql-bugs@arkaria.postgresql.org; Sat, 09 May 2020 03:26:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jXG8F-0000Mw-UW for pgsql-bugs@arkaria.postgresql.org; Sat, 09 May 2020 03:26:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXG8F-0000ML-OC; Sat, 09 May 2020 03:26:31 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXG8C-0007Co-ID; Sat, 09 May 2020 03:26:30 +0000 Received: from hnk.local (p2358024-ipbf2221funabasi.chiba.ocn.ne.jp [114.177.56.24]) by oss.nttdata.com (Postfix) with ESMTPSA id 40B9A60384; Sat, 9 May 2020 12:26:23 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI. From: Fujii Masao To: Amit Kapila Cc: David Steele , Kyotaro Horiguchi , psuderevsky@gmail.com, PostgreSQL Hackers , PostgreSQL mailing lists References: <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net> <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com> <20200407.164801.1830442317313243264.horikyota.ntt@gmail.com> <4a461c7b-b90a-6644-64a6-80eac69c27bc@pgmasters.net> <21d2590f-2739-9f45-748f-7a68d667d7cd@oss.nttdata.com> <9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com> Message-ID: <9d7ad280-9ce8-a538-83a3-29c57583f1ef@oss.nttdata.com> Date: Sat, 9 May 2020 12:26:22 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/05/08 14:23, Fujii Masao wrote: > > > On 2020/05/07 17:57, Amit Kapila wrote: >> On Thu, May 7, 2020 at 12:13 PM Fujii Masao wrote: >>> >>> On 2020/05/02 20:40, Amit Kapila wrote: >>>> >>>> I don't see any obvious problem with the changed code but we normally >>>> don't backpatch performance improvements.  I can see that the code >>>> change here appears to be straight forward so it might be fine to >>>> backpatch this.  Have we seen similar reports earlier as well?  AFAIK, >>>> this functionality is for a long time and if people were facing this >>>> on a regular basis then we would have seen such reports multiple >>>> times.  I mean to say if the chances of this hitting are less then we >>>> can even choose not to backpatch this. >>> >>> I found the following two reports. ISTM there are not so many reports... >>> https://www.postgresql.org/message-id/16159-f5a34a3a04dc67e0@postgresql.org >>> https://www.postgresql.org/message-id/dd6690b0-ec03-6b3c-6fac-c963f91f87a7%40postgrespro.ru >>> >> >> The first seems to be the same where this bug has been fixed.  It has >> been moved to hackers in email [1]. > > Yes, that's the original report that leaded to the commit. > >>  Am, I missing something? >> Considering it has been encountered by two different people, I think >> it would not be a bad idea to back-patch this. > > +1 So I will do the back-patch. Done. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION