Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rrsrT-003KND-Aw for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Apr 2024 05:08:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rrsrR-00F8mm-CW for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Apr 2024 05:08:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rrsrQ-00F8kZ-U7 for pgsql-hackers@lists.postgresql.org; Wed, 03 Apr 2024 05:08:33 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rrsrN-000MNy-5U for pgsql-hackers@lists.postgresql.org; Wed, 03 Apr 2024 05:08:31 +0000 Received: from [127.0.0.1] (qilin85.starlink.ru [77.50.204.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: m.zhilin@postgrespro.ru) by mail.postgrespro.ru (Postfix/465) with ESMTPSA id 50F6CE20E92; Wed, 3 Apr 2024 08:08:27 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1712120907; bh=6J0tMJukyF5+QE/9IY+ryKfQUM7KNPkQyrKf3jOzuzA=; h=Date:From:To:CC:Subject:User-Agent:In-Reply-To:References: Message-ID:From; b=x1KfWG+Frih7eoXQU2ZuqrNHi2RcbiGpmaAcC3DbnhVJKBi3DAZzhnbBDZnBdEsZa pi7A/wo0f7FfnnxkpD9JwKrykbstpXZMvkMbhSANIer1DsD0l250cWYLrKEDjuvGQQ tildiXs4QwiMnaHWwQufr08tBjHExmc3Hh1ThzHeUVp16Zh/a585Wka+VVfvKbZhHn JCVIJwLWUKGURqvKsP+nDXpUoReByUEx3MEZc3b/yOI/E8CuaZGlqjE+m0mjggv+4H +yZanMonawTUQzDPjFF1rwJKCP3E9Rj5yItvaZjvTYYBFcqoDxSgFIyr54zISvGD3s gs/uWZvV4Tkkg== Date: Wed, 03 Apr 2024 08:08:26 +0300 From: Michael Zhilin To: Tom Lane , Akshat Jaimini CC: pgsql-hackers@lists.postgresql.org Subject: =?US-ASCII?Q?Re=3A_BUG=3A_deadlock_between_au?= =?US-ASCII?Q?tovacuum_worker_and_client_ba?= =?US-ASCII?Q?ckend_during_removal_of_orphan_temp_tables_with_sequences?= User-Agent: K-9 Mail for Android In-Reply-To: <1731082.1712084694@sss.pgh.pa.us> References: <2B25F88E-E6AA-4883-B21B-936F7B5D5F78@yandex-team.ru> <171170826140.2046436.12738244831107414180.pgcf@coridan.postgresql.org> <1731082.1712084694@sss.pgh.pa.us> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----GPJX6PHM7SR0Y2LH8NHVAKBG0ZR8VL Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ------GPJX6PHM7SR0Y2LH8NHVAKBG0ZR8VL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks to all for review, testing and commit!!!=20 On 2 April 2024 22:04:54 GMT+03:00, Tom Lane wro= te: >Akshat Jaimini writes: >> The code seems to implement the feature and has good and explanatory co= mments associated with it=2E >> I believe we can go ahead with committing patch although I would reques= t some senior contributors to also take a look at this patch since I am rel= atively new to patch reviews=2E > >Looks like a good catch and a reasonable fix=2E Pushed after rewriting >the comments a bit=2E > >As far as this goes: > >> I ran make installcheck-world after applying the patch and recompiling = it=2E It did fail for a particular test but from the logs it seems to be un= related to this particular patch since it fails for the following: > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> select error_trap_test(); >> - error_trap_test =20 >> ---------------------------- >> - division_by_zero detected >> -(1 row) >> - >> +ERROR: cannot start subtransactions during a parallel operation > >=2E=2E=2E that's the test case from 0075d7894, and the failure is what >I'd expect from a backend older than that=2E Maybe you forgot to >recompile/reinstall after updating past that commit? > > regards, tom lane ------GPJX6PHM7SR0Y2LH8NHVAKBG0ZR8VL Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks to all for review, testin= g and commit!!!


On 2 April 2024 22:04:54 GMT+03:00, Tom Lane <tgl@sss=2Epgh=2Epa=2Eu= s> wrote:
Akshat Jaimini <destrex271@gmai=
l=2Ecom> writes:
The code seems to implement the feature and has good a=
nd explanatory comments associated with it=2E
I believe we can go ahead =
with committing patch although I would request some senior contributors to =
also take a look at this patch since I am relatively new to patch reviews=
=2E

Looks like a good catch and=
 a reasonable fix=2E  Pushed after rewriting
the comments a bit=2E
As far as this goes:

I ran make installcheck-world after applying th=
e patch and recompiling it=2E It did fail for a particular test but from th=
e logs it seems to be unrelated to this particular patch since it fails for=
 the following:

select error_=
trap_test();
-      error_trap_test      
- division_by_zero detected=

-(1 row)
-
+ERROR:  cannot start subtransactions during a paralle=
l operation

=2E=2E=2E that's th= e test case from 0075d7894, and the failure is what
I'd expect from a ba= ckend older than that=2E Maybe you forgot to
recompile/reinstall after = updating past that commit?

regards, tom lane
------GPJX6PHM7SR0Y2LH8NHVAKBG0ZR8VL--