Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20190817224142.gq57z3cwt7c76dtk@alap3.anarazel.de>
Date: Sat, 17 Aug 2019 16:29:53 -0700
Cc: <jungleboogie0@gmail.com>, <pgsql-bugs@lists.postgresql.org>, "Michael
 Paquier" <michael@paquier.xyz>
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared
 identifier 'FD_SETSIZE'
From: "jungle boogie" <jungleboogie0@gmail.com>
To: "Andres Freund" <andres@anarazel.de>, "Tom Lane" <tgl@sss.pgh.pa.us>
Message-Id: <BWCANM4UM2QO.1MGZKCFFDRFPM@beginning.in.lylie.net>
Precedence: bulk

On Sat Aug 17, 2019 at 3:41 PM Andres Freund wrote:
> Hi,
>=20
> Heh, just discovered
> https://www.postgresql.org/message-id/20160921171819.1357.29774%40wrigley=
s.postgresql.org
> from the same reporter, where we went through this before :/

Oh, wow! Sorry I didn't remember that. Guess I didn't do a good enough job
searching through the archives.

>=20
>=20
> On 2019-08-17 17:59:05 -0400, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > On 2019-08-17 16:31:01 -0400, Tom Lane wrote:
> > >> PG Bug reporting form <noreply@postgresql.org> writes:
> > >>> vacuumdb.c:184:26: error: use of undeclared identifier 'FD_SETSIZE'
> >=20
> > >> Hmm, it seems somebody removed the "#include <sys/select.h>" from
> > >> that file, which was a pretty not-bright idea.
> >=20
> > > Most of the parallel code was move into bin/scripts/scripts_parallel.=
c -
> > > but there's still the above error check. Seems like we ought to add a
> > > ParallelSlotsMax() or such, and use that in the error check, rather t=
han
> > > check FD_SETSIZE directly?
> >=20
> > Yeah, that would likely be cleaner than just responding to this directl=
y.
>=20
> I'll go and do that.
>=20
>=20
> > >> But I wonder why the OpenBSD machines in the buildfarm aren't compla=
ining.
> >=20
> > > Or even why it works on other platforms.
> >=20
> > Indeed.  I've confirmed the bug report on a local OpenBSD 6.4 build
> > (clang 6.0.0), and with "make -k" I can see that reindexdb.c fails
> > likewise.  But this is unsurprising given that POSIX says that
> > FD_SETSIZE is declared by sys/select.h.
>=20
> Right.

I noticed all the machines in your buildfarm are running OpenBSD 5.9 from M=
arch
2016 and I believe before clang was the default compiler. I'll see what I c=
an
find on local craigslist for inexpensive amd64 machines and then have it bu=
ild
Postgres.

Thanks for the efforts you two have put into tracking this down.