MIME-Version: 1.0
References: <19484-a3cb82c8cde3c8fa@postgresql.org>
 <CAJTYsWXY9C3B-7NZw72OKen2L2rZt=c-t6=kjTJzgj=ZaNPe8g@mail.gmail.com>
 <DIPI7GSQFV1C.20OALZACS6KLI@gmail.com>
 <CA+FpmFc10Dtnr9dr=xqK2cNYQ4-1VuOyvOT7-eqXPmiQJoyPew@mail.gmail.com>
 <DJ4M4TOUHLM0.B38DAVN79FPH@gmail.com>
 <CAJTYsWWUfgCZau2fvrZVruXmC+dyOx45L=TyaGzXdywsywDyHQ@mail.gmail.com>
 <DJ5BM93JVJ7C.MQC43GITCBOY@gmail.com>
 <CA+HiwqHVMY1a5E+6Ei369+RqQ8qKSSgon_C=3yBk-TPJDwZ2nQ@mail.gmail.com>
 <CA+HiwqHjUO0uXFZ2dECJiNime6B1FDL5+mJ=XN+1XgzkY=m9DA@mail.gmail.com>
 <CAPmGK16GNiwcnAxM3XU=ZTOP_8oiv7_FOUwo5hZp8b+qfv2L7g@mail.gmail.com>
 <CA+HiwqEVwEPSE4yMvuwVT5bb+ziMHLfqd_HuiQPAFAixNHbhrQ@mail.gmail.com>
In-Reply-To: 
 <CA+HiwqEVwEPSE4yMvuwVT5bb+ziMHLfqd_HuiQPAFAixNHbhrQ@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Thu, 18 Jun 2026 18:15:44 +0900
Message-ID: 
 <CA+HiwqHO0Bbi6cyk4F+UGvZEV3NEo7o0YT3-Js7K7hvasoWBVw@mail.gmail.com>
Subject: Re: BUG #19484: Segmentation fault triggered by FDW
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>,
 Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	Rafia Sabih <rafia.pghackers@gmail.com>, 798604270@qq.com,
	pgsql-bugs@lists.postgresql.org, Amit Langote <amitlan@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqHO0Bbi6cyk4F%2BUGvZEV3NEo7o0YT3-Js7K7hvasoWBVw%40mail.gmail.com>
Precedence: bulk

Fujita-san,

On Thu, Jun 11, 2026 at 7:44=E2=80=AFPM Amit Langote <amitlangote09@gmail.c=
om> wrote:
>
> Hi Fujita-san,
>
> On Thu, Jun 11, 2026 at 7:41=E2=80=AFPM Etsuro Fujita <etsuro.fujita@gmai=
l.com> wrote:
> >
> > Amit-san,
> >
> > On Wed, Jun 10, 2026 at 10:27=E2=80=AFPM Amit Langote <amitlangote09@gm=
ail.com> wrote:
> > > Before committing it, I'd like to wait briefly to see if Fujita-san
> > > has any thoughts on the FDW-side concerns, since he has already chime=
d
> > > in on the thread.
> >
> > I'll review the patch as early as I can next week, but if you want to
> > commit it quickly, please go ahead.
>
> No problem; I'll hold off.

A small clarification on this one: the patch makes no changes to
postgres_fdw code, only adds a regression test. The bug, which I
introduced, is in how nodeModifyTable.c supplies fdw_private from the
pruned/validated fdwPrivLists in ModifyTableState rather than the
original list in ModifyTable, so the postgres_fdw side itself is
unchanged. The substantive change is the executor re-indexing.

Still holding off on committing per our exchange, but no rush given
you may want to prioritize the v19 open items. Happy to go ahead
whenever, or wait for your comments.

--=20
Thanks, Amit Langote